From: Bjorn Helgaas <helgaas@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets
Date: Tue, 20 Jul 2021 19:02:53 -0500 [thread overview]
Message-ID: <20210721000253.GA143407@bjorn-Precision-5520> (raw)
In-Reply-To: <20210720075025.GA17565@lst.de>
On Tue, Jul 20, 2021 at 09:50:25AM +0200, Christoph Hellwig wrote:
> > +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd)
> > +{
> > + /*
> > + * Simple invocations do not provide a calc_sets() callback. Call
> > + * the generic one.
> > + */
> > + if (!affd->calc_sets)
> > + default_calc_sets(affd, affvecs);
> > + else
> > + affd->calc_sets(affd, affvecs);
>
> Nit: avoid pointless negations:
>
> if (affd->calc_sets)
> affd->calc_sets(affd, affvecs);
> else
> default_calc_sets(affd, affvecs);
+1
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for doing this! For the PCI part:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
prev parent reply other threads:[~2021-07-21 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 4:42 [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets Ming Lei
2021-07-20 7:50 ` Christoph Hellwig
2021-07-21 0:02 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721000253.GA143407@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).