From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Hannes Reinecke <hare@suse.de>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH v2 0/6] PCI/VPD: pci_vpd_size() cleanups
Date: Thu, 29 Jul 2021 13:42:28 -0500 [thread overview]
Message-ID: <20210729184234.976924-1-helgaas@kernel.org> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
The basic idea is to validate VPD resource *size* without validating the
actual content, since the kernel really doesn't care about the content.
Thanks very much for the feedback on v1, and I'd be glad for any additional
feedback.
Follow-up to:
https://lore.kernel.org/r/20210715215959.2014576-1-helgaas@kernel.org
Changes since v1:
- Incorporate Heiner's patch to reject VPD if first byte is 0x00 or 0xff
(https://lore.kernel.org/r/8de8c906-9284-93b9-bb44-4ffdc3470740@gmail.com/)
- Update size checks to reject resources that would extend past the
maximum VPD size
Bjorn Helgaas (5):
PCI/VPD: Correct diagnostic for VPD read failure
PCI/VPD: Check Resource Item Names against those valid for type
PCI/VPD: Reject resource tags with invalid size
PCI/VPD: Don't check Large Resource Item Names for validity
PCI/VPD: Allow access to valid parts of VPD if some is invalid
Heiner Kallweit (1):
PCI/VPD: Treat initial 0xff as missing EEPROM
drivers/pci/vpd.c | 55 +++++++++++++++++++++--------------------------
1 file changed, 25 insertions(+), 30 deletions(-)
--
2.25.1
next reply other threads:[~2021-07-29 18:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 18:42 Bjorn Helgaas [this message]
2021-07-29 18:42 ` [PATCH v2 1/6] PCI/VPD: Correct diagnostic for VPD read failure Bjorn Helgaas
2021-07-29 18:42 ` [PATCH v2 2/6] PCI/VPD: Check Resource Item Names against those valid for type Bjorn Helgaas
2021-07-29 18:42 ` [PATCH v2 3/6] PCI/VPD: Treat initial 0xff as missing EEPROM Bjorn Helgaas
2021-07-30 6:04 ` Hannes Reinecke
2021-07-29 18:42 ` [PATCH v2 4/6] PCI/VPD: Reject resource tags with invalid size Bjorn Helgaas
2021-07-30 6:07 ` Hannes Reinecke
2021-08-09 18:15 ` Qian Cai
2021-08-09 18:46 ` Bjorn Helgaas
2021-08-09 18:57 ` Heiner Kallweit
2021-07-29 18:42 ` [PATCH v2 5/6] PCI/VPD: Don't check Large Resource Item Names for validity Bjorn Helgaas
2021-07-29 18:42 ` [PATCH v2 6/6] PCI/VPD: Allow access to valid parts of VPD if some is invalid Bjorn Helgaas
2021-08-02 22:29 ` [PATCH v2 0/6] PCI/VPD: pci_vpd_size() cleanups Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729184234.976924-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=hare@suse.de \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).