From: Alex Williamson <alex.williamson@redhat.com>
To: "Rustad, Mark D" <mark.d.rustad@intel.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Alexander Duyck <alexanderduyck@fb.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Subject: Re: [PATCH 2/6] PCI/VPD: Remove struct pci_vpd_ops
Date: Wed, 11 Aug 2021 17:58:42 -0600 [thread overview]
Message-ID: <20210811175842.2ed7c87b.alex.williamson@redhat.com> (raw)
In-Reply-To: <81BDA19D-B2AC-433A-B16F-4EB88A070B5B@intel.com>
On Wed, 11 Aug 2021 23:43:43 +0000
"Rustad, Mark D" <mark.d.rustad@intel.com> wrote:
> at 3:00 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> > So I wonder if we should just disallow VPD access for these NICs
> > except on function 0. There was a little bit of discussion in that
> > direction at [2].
>
> If this is done, you'll have to be sure that any non-0 functions assigned
> to guests (which will appear as function 0 to the guest!) does not appear
> to have VPD and block access to those resources. That seems kind of messy,
> but should work. One hopes that no guest drivers are hard-wired to assume
> VPD presence based on the device type.
A bit messy, yes. But if we're saying VPD is not essential for
operation in the VM, I'd rather we mask it on all functions rather than
create scenarios where different identical functions produce different
userspace results. Thanks,
Alex
next prev parent reply other threads:[~2021-08-11 23:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 17:18 [PATCH 0/6] PCI/VPD: Further improvements Heiner Kallweit
2021-08-08 17:19 ` [PATCH 1/6] PCI/VPD: Move pci_read/write_vpd in the code Heiner Kallweit
2021-08-08 17:20 ` [PATCH 2/6] PCI/VPD: Remove struct pci_vpd_ops Heiner Kallweit
2021-08-11 22:00 ` Bjorn Helgaas
2021-08-11 23:43 ` Rustad, Mark D
2021-08-11 23:58 ` Alex Williamson [this message]
2021-08-08 17:21 ` [PATCH 3/6] PCI/VPD: Remove member valid from struct pci_vpd Heiner Kallweit
2021-08-08 17:21 ` [PATCH 4/6] PCI/VPD: Embed struct pci_vpd member in struct pci_dev Heiner Kallweit
2021-08-08 17:22 ` [PATCH 5/6] PCI/VPD: Determine VPD size in pci_vpd_init already Heiner Kallweit
2021-08-08 17:23 ` [PATCH 6/6] PCI/VPD: Treat invalid VPD like no VPD capability Heiner Kallweit
2021-08-12 17:53 ` [PATCH 0/6] PCI/VPD: Further improvements Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811175842.2ed7c87b.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=alexanderduyck@fb.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).