From: "Krzysztof Wilczyński" <kw@linux.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
x86@kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/pci: Add missing forward declaration for pci_numachip_init()
Date: Thu, 12 Aug 2021 18:11:56 +0200 [thread overview]
Message-ID: <20210812161156.GA563797@rocinante> (raw)
In-Reply-To: <87y296hez9.ffs@tglx>
Hi Thomas,
[...]
> > What should be done with the pci_numachip_init() declaration in
> > arch/x86/include/asm/numachip/numachip.h? It doesn't seem like we
> > should have *two* declarations.
>
> Right. Include that file in the C file and be done with it.
I will send v2 shortly with the correct header file included.
Thank you both!
Krzysztof
next prev parent reply other threads:[~2021-08-12 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 23:40 [PATCH] x86/pci: Add missing forward declaration for pci_numachip_init() Krzysztof Wilczyński
2021-07-30 21:19 ` Bjorn Helgaas
2021-08-12 15:14 ` Thomas Gleixner
2021-08-12 16:11 ` Krzysztof Wilczyński [this message]
2021-08-12 15:05 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812161156.GA563797@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox