Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Stephen Bates" <sbates@raithlin.com>,
	linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: fix a scheduling in atomic bug
Date: Fri, 13 Aug 2021 10:27:50 +0300	[thread overview]
Message-ID: <20210813072750.GB1931@kadam> (raw)
In-Reply-To: <065519bd-d73c-0d0e-182d-6431914d0e8d@deltatee.com>

On Thu, Aug 12, 2021 at 09:19:42AM -0600, Logan Gunthorpe wrote:
> 
> 
> 
> On 2021-08-12 1:00 a.m., Dan Carpenter wrote:
> > This function is often called with a spinlock held so the allocation has
> > to be atomic.  The call tree is:
> > 
> > pci_specified_resource_alignment() <-- takes spin_lock();
> >  -> pci_dev_str_match()
> >     -> pci_dev_str_match_path()
> > 
> > Fixes: 07d8d7e57c28 ("PCI: Make specifying PCI devices in kernel parameters reusable")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> This looks good to me, but I think the fixes tag is wrong.
> pci_dev_str_match_path() was introduced in this patch:
> 
> Fixes: 45db33709ccc ("PCI: Allow specifying devices using a base bus and
> path of devfns")

Yeah.  You're right.  Thanks.  Thanks, Bjorn for fixing this.

regards,
dan carpenter


  reply	other threads:[~2021-08-13  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  7:00 [PATCH] PCI: fix a scheduling in atomic bug Dan Carpenter
2021-08-12 15:19 ` Logan Gunthorpe
2021-08-13  7:27   ` Dan Carpenter [this message]
2021-08-12 19:16 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210813072750.GB1931@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=christian.koenig@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox