From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA38C433FE for ; Sat, 11 Sep 2021 23:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C03636109F for ; Sat, 11 Sep 2021 23:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234664AbhIKX4A (ORCPT ); Sat, 11 Sep 2021 19:56:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49642 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234598AbhIKXz7 (ORCPT ); Sat, 11 Sep 2021 19:55:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631404485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhzTiX0DZYV1X5ckSDoJZp4U7aZCZRTdTtc5atz14SI=; b=HIYOtFgY4HxMNyU0nzLti5A8vG2pVu6p4v3N2hqr9VCqnSjvaEgH03c0xLylchB2XX6JhZ MZja69E6+/mBnkFFoaH07qfH2BNOXewJXF/fF6FcQeepTpcoGIs0L1KGN//6havxYew7HX 7hUkBeY6or6zno1I58JXf2KSUB2lf60= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-YkRABu7ENqa4nnKiMbUSCA-1; Sat, 11 Sep 2021 19:54:44 -0400 X-MC-Unique: YkRABu7ENqa4nnKiMbUSCA-1 Received: by mail-ej1-f72.google.com with SMTP id c25-20020a170906341900b005eea9bf6f4aso793515ejb.12 for ; Sat, 11 Sep 2021 16:54:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XhzTiX0DZYV1X5ckSDoJZp4U7aZCZRTdTtc5atz14SI=; b=N/CMsI13V1THNNV3cjFINODa0ugjxqcF4I6WtiJbtuRTVW4KRgPtskjj6HWU8mXHCU LG0PGG6JOHcLO8QL8vmk4j+0cXvWK+3NrFCjJsBXfGk0Q7J50l4fFqiyFEJnjVGqSnA7 4gMRLrHEEcpF+r25qdJhhw+iK2kgsCtt6H/wNIEPQN6BVeTN3w40BrWh0wYC0+486n81 +bwnef/XovQJhNArRKMsyJuVbo8UvqrHExvB0nAPcnDUkp/cIcEDiOUAjX9OHGc7Vl9p C1DUhwwnhPqWJ61aXiDsCok/cQ1TbGjdFKq6JV5t54a+CjmDAL/YdqmpnEMHOkOnm0+g 6puw== X-Gm-Message-State: AOAM532LGbF7bmD6mFJgxKTRel7DNyfsJpl4gcMbj3oZZCy/Pf4wDfhR 2fECXgRi4qfP1ZFFl9ZvF0gjljdV7FWd2meuovjSddqQt0Slhyu7icN+xql7ku67lNOXDD6u5Tl LX0mbd3Mz/lAkkOUvz7Dm X-Received: by 2002:a17:906:5855:: with SMTP id h21mr4944819ejs.230.1631404482988; Sat, 11 Sep 2021 16:54:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUJ/Dz7qpoDYQNg7a7mY8Cl7pe7fwOabdq++HQzqfzjVSc2KbxoH+7byBLBBXMvIdUmNqg2Q== X-Received: by 2002:a17:906:5855:: with SMTP id h21mr4944788ejs.230.1631404482774; Sat, 11 Sep 2021 16:54:42 -0700 (PDT) Received: from redhat.com ([2.55.27.174]) by smtp.gmail.com with ESMTPSA id n13sm1309780ejk.97.2021.09.11.16.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Sep 2021 16:54:41 -0700 (PDT) Date: Sat, 11 Sep 2021 19:54:36 -0400 From: "Michael S. Tsirkin" To: Andi Kleen Cc: Dan Williams , "Kuppuswamy, Sathyanarayanan" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , Bjorn Helgaas , Richard Henderson , Thomas Bogendoerfer , James E J Bottomley , Helge Deller , "David S . Miller" , Arnd Bergmann , Jonathan Corbet , Peter H Anvin , Dave Hansen , Tony Luck , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , X86 ML , Linux Kernel Mailing List , Linux PCI , linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch , Linux Doc Mailing List , virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 11/15] pci: Add pci_iomap_shared{,_range} Message-ID: <20210911195006-mutt-send-email-mst@kernel.org> References: <20210824053830-mutt-send-email-mst@kernel.org> <20210829112105-mutt-send-email-mst@kernel.org> <09b340dd-c8a8-689c-4dad-4fe0e36d39ae@linux.intel.com> <20210829181635-mutt-send-email-mst@kernel.org> <3a88a255-a528-b00a-912b-e71198d5f58f@linux.intel.com> <20210830163723-mutt-send-email-mst@kernel.org> <69fc30f4-e3e2-add7-ec13-4db3b9cc0cbd@linux.intel.com> <20210910054044-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Sep 10, 2021 at 09:34:45AM -0700, Andi Kleen wrote: > > > that's why > > > an extra level of defense of ioremap opt-in is useful. > > OK even assuming this, why is pci_iomap opt-in useful? > > That never happens before probe - there's simply no pci_device then. > > > Hmm, yes that's true. I guess we can make it default to opt-in for > pci_iomap. > > It only really matters for device less ioremaps. OK. And same thing for other things with device, such as devm_platform_ioremap_resource. If we agree on all that, this will basically remove virtio changes from the picture ;) -- MST