From: Bjorn Helgaas <helgaas@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Dave Jones <davej@codemonkey.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Linux 5.15-rc1
Date: Mon, 13 Sep 2021 15:09:42 -0500 [thread overview]
Message-ID: <20210913200942.GA1351739@bjorn-Precision-5520> (raw)
In-Reply-To: <CAHk-=wgUJe9rsM5kbmq7jLZc2E6N6XhYaeW9-zJgWaDC-wDiuw@mail.gmail.com>
On Mon, Sep 13, 2021 at 12:51:30PM -0700, Linus Torvalds wrote:
> On Mon, Sep 13, 2021 at 12:00 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> >
> > With an older kernel you may experience the stall when accessing the vpd
> > attribute of this device in sysfs.
>
> Honestly, that old behavior seems to be the *much* better behavior.
>
> A synchronous stall at boot time is truly annoying, and a pain to deal
> with (and debug).
>
> That pci_vpd_read() function is clearly NOT designed to deal with
> boot-time callers in the first place, so I think that commit is simply
> wrong.
>
> And yes, I see that "128ms timeout". If it was _one_ timeout, that
> would be one thing,. But it looks like it's repeated over and over.
>
> Not acceptable at boot time. Not at all.
>
> Bjorn. Please revert. Or I can do it.
Sorry about this.
Dave said it wasn't a trivial revert, but I'll be happy to work with
Heiner and Dave to revert and test it.
I agree that we shouldn't read VPD at boot-time unless we actually
need the data then.
Bjorn
next prev parent reply other threads:[~2021-09-13 20:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHk-=wgbygOb3hRV+7YOpVcMPTP2oQ=iw6tf09Ydspg7o7BsWQ@mail.gmail.com>
[not found] ` <20210913141818.GA27911@codemonkey.org.uk>
2021-09-13 18:59 ` Linux 5.15-rc1 Heiner Kallweit
2021-09-13 19:51 ` Linus Torvalds
2021-09-13 20:09 ` Bjorn Helgaas [this message]
2021-09-13 20:11 ` Heiner Kallweit
2021-09-13 20:15 ` Linus Torvalds
2021-09-13 20:15 ` Dave Jones
2021-09-13 20:22 ` Heiner Kallweit
2021-09-13 20:32 ` Dave Jones
2021-09-13 20:44 ` Linux 5.15-rc1 - 82599ES VPD access isue Heiner Kallweit
2021-09-13 23:32 ` [Intel-wired-lan] " Hisashi T Fujinaka
2021-09-14 5:51 ` Heiner Kallweit
2021-09-14 14:24 ` Dave Jones
2021-09-14 18:28 ` Fujinaka, Todd
2021-09-14 20:00 ` Hisashi T Fujinaka
2021-09-14 21:51 ` Heiner Kallweit
2021-09-15 14:18 ` Hisashi T Fujinaka
2021-09-15 16:05 ` Heiner Kallweit
2021-09-15 16:16 ` Hisashi T Fujinaka
2021-09-15 22:32 ` Bjorn Helgaas
2021-09-15 23:46 ` Hisashi T Fujinaka
2021-09-17 15:09 ` Bjorn Helgaas
2021-09-13 20:59 ` Linux 5.15-rc1 Heiner Kallweit
2021-09-13 23:35 ` Bjorn Helgaas
2021-09-13 20:32 ` Heiner Kallweit
2021-09-13 20:36 ` Linus Torvalds
2021-09-13 20:41 ` Dave Jones
2021-09-13 23:46 ` Bjorn Helgaas
2021-09-14 0:39 ` Dave Jones
2021-09-14 6:21 ` Heiner Kallweit
2021-09-14 11:26 ` Bjorn Helgaas
2021-09-14 17:07 ` Heiner Kallweit
2021-09-14 21:55 ` Bjorn Helgaas
2021-09-14 22:06 ` Heiner Kallweit
2021-09-14 22:33 ` Dave Jones
2021-09-15 21:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913200942.GA1351739@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=davej@codemonkey.org.uk \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox