From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Dave Jones <davej@codemonkey.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: Linux 5.15-rc1
Date: Tue, 14 Sep 2021 06:26:28 -0500 [thread overview]
Message-ID: <20210914112628.GA1412445@bjorn-Precision-5520> (raw)
In-Reply-To: <870c3332-db60-9cf5-0439-247f91ce7808@gmail.com>
On Tue, Sep 14, 2021 at 08:21:46AM +0200, Heiner Kallweit wrote:
> On 14.09.2021 01:46, Bjorn Helgaas wrote:
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID, quirk_blacklist_vpd);
> > /*
>
> Leaving the quirks in FIXUP_HEADER stage would have the advantage that for
> blacklisted devices the vpd sysfs attribute isn't visibale. The needed
> changes to the patch are minimal.
What do you have in mind? The only thing I can think of would be to
add a "pci_dev.no_vpd" bit. "vpd.cap == 0" means the device has no
VPD, and "vpd.len == 0" means we haven't determined the size yet. All
devices start off with vpd.cap == 0 and vpd.len == 0, so a
FIXUP_HEADER quirk would have to set a sentinel value or some other
bit.
Bjorn
next prev parent reply other threads:[~2021-09-14 11:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHk-=wgbygOb3hRV+7YOpVcMPTP2oQ=iw6tf09Ydspg7o7BsWQ@mail.gmail.com>
[not found] ` <20210913141818.GA27911@codemonkey.org.uk>
2021-09-13 18:59 ` Linux 5.15-rc1 Heiner Kallweit
2021-09-13 19:51 ` Linus Torvalds
2021-09-13 20:09 ` Bjorn Helgaas
2021-09-13 20:11 ` Heiner Kallweit
2021-09-13 20:15 ` Linus Torvalds
2021-09-13 20:15 ` Dave Jones
2021-09-13 20:22 ` Heiner Kallweit
2021-09-13 20:32 ` Dave Jones
2021-09-13 20:44 ` Linux 5.15-rc1 - 82599ES VPD access isue Heiner Kallweit
2021-09-13 23:32 ` [Intel-wired-lan] " Hisashi T Fujinaka
2021-09-14 5:51 ` Heiner Kallweit
2021-09-14 14:24 ` Dave Jones
2021-09-14 18:28 ` Fujinaka, Todd
2021-09-14 20:00 ` Hisashi T Fujinaka
2021-09-14 21:51 ` Heiner Kallweit
2021-09-15 14:18 ` Hisashi T Fujinaka
2021-09-15 16:05 ` Heiner Kallweit
2021-09-15 16:16 ` Hisashi T Fujinaka
2021-09-15 22:32 ` Bjorn Helgaas
2021-09-15 23:46 ` Hisashi T Fujinaka
2021-09-17 15:09 ` Bjorn Helgaas
2021-09-13 20:59 ` Linux 5.15-rc1 Heiner Kallweit
2021-09-13 23:35 ` Bjorn Helgaas
2021-09-13 20:32 ` Heiner Kallweit
2021-09-13 20:36 ` Linus Torvalds
2021-09-13 20:41 ` Dave Jones
2021-09-13 23:46 ` Bjorn Helgaas
2021-09-14 0:39 ` Dave Jones
2021-09-14 6:21 ` Heiner Kallweit
2021-09-14 11:26 ` Bjorn Helgaas [this message]
2021-09-14 17:07 ` Heiner Kallweit
2021-09-14 21:55 ` Bjorn Helgaas
2021-09-14 22:06 ` Heiner Kallweit
2021-09-14 22:33 ` Dave Jones
2021-09-15 21:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914112628.GA1412445@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).