Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/4] PCI/sysfs: Check CAP_SYS_ADMIN before parsing user input
Date: Wed, 15 Sep 2021 03:15:36 +0200	[thread overview]
Message-ID: <20210915011536.GB1444093@rocinante> (raw)
In-Reply-To: <20210914204014.GA1455147@bjorn-Precision-5520>

Hi Bjorn,

[...]
> > Check if the "CAP_SYS_ADMIN" capability flag is set before parsing user
> > input as it makes more sense to first check whether the current user
> > actually has the right permissions before accepting any input from such
> > user.
> > 
> > This will also make order in which enable_store() and msi_bus_store()
> > perform the "CAP_SYS_ADMIN" capability check consistent with other
> > PCI-related sysfs objects that first verify whether user has this
> > capability set.
> 
> I like this one.  Can you rebase it to skip patch 1/4 (unless you
> convince me that 1/4 is safe)?

I will remove it, as per:
  https://lore.kernel.org/linux-pci/20210915011204.GA1444093@rocinante/T/#t

Thank you!

	Krzysztof

  reply	other threads:[~2021-09-15  1:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 21:23 [PATCH 1/4] PCI/sysfs: Move to kstrtobool() to handle user input Krzysztof Wilczyński
2021-07-05 21:23 ` [PATCH 2/4] PCI/sysfs: Check CAP_SYS_ADMIN before parsing " Krzysztof Wilczyński
2021-09-14 20:40   ` Bjorn Helgaas
2021-09-15  1:15     ` Krzysztof Wilczyński [this message]
2021-07-05 21:23 ` [PATCH 3/4] PCI/sysfs: Return -EINVAL consistently from "store" functions Krzysztof Wilczyński
2021-07-06  0:24   ` kernel test robot
2021-07-06  0:35     ` Krzysztof Wilczyński
2021-07-05 21:23 ` [PATCH 4/4] PCI: Don't use the strtobool() wrapper for kstrtobool() Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210915011536.GB1444093@rocinante \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox