From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 344C4C433FE for ; Wed, 15 Sep 2021 21:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1576960041 for ; Wed, 15 Sep 2021 21:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232258AbhIOVqh (ORCPT ); Wed, 15 Sep 2021 17:46:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:51010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232127AbhIOVqg (ORCPT ); Wed, 15 Sep 2021 17:46:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 27BFD60FDA; Wed, 15 Sep 2021 21:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631742317; bh=0tlvgoU75wbHpOdojhqsdvJcxuTlS5gMsH/qYcOFBq0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=kY03ZoBxxSpUsIKaI9UwnmWshfkjKVFQWGCPqfkrQz7+cZHS4wEMN5M+rGpfVTZOd 9BhG2gPoZbPaxK6FVDWyOkxxpx32H/OmuGe0eaL7L+jvcaSsLBv1/Tymw70vn0Jg5w PxccFC/cHIoPMkUUH1UIRSLpS1VMIepxDLrKf8OfBpBf5t13BMiAqWZqMh2Wtehxp2 EllO6vmeOCXeB3PcfkMORSS/5vJxSflYVThEHy/pLE6cEHyI0G+p5rK3Skw16vN7Go WZlVuszb3vhONfblUlMTKogeYmCnIS1d1CctTNuVuk8turuaROErOC4iNPQGMm8mr7 0C5sj/+nUAygg== Date: Wed, 15 Sep 2021 16:45:15 -0500 From: Bjorn Helgaas To: "Deucher, Alexander" Cc: "Quan, Evan" , "linux-pci@vger.kernel.org" , "bhelgaas@google.com" , "stable@vger.kernel.org" Subject: Re: [PATCH] PCI: Create device links for AMD integrated USB xHCI and UCSI controllers Message-ID: <20210915214515.GA1541334@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Sep 15, 2021 at 04:39:36PM +0000, Deucher, Alexander wrote: > [Public] > > > -----Original Message----- > > From: Bjorn Helgaas > > Sent: Tuesday, September 14, 2021 11:29 AM > > To: Quan, Evan > > Cc: linux-pci@vger.kernel.org; bhelgaas@google.com; Deucher, Alexander > > ; stable@vger.kernel.org > > Subject: Re: [PATCH] PCI: Create device links for AMD integrated USB xHCI > > and UCSI controllers > > > > On Fri, Sep 03, 2021 at 02:33:11PM +0800, Evan Quan wrote: > > > Latest AMD GPUs have built-in USB xHCI and UCSI controllers. Add > > > device link support for them. > > > > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Evan Quan > > > > Applied to pci/pm for v5.16, thanks! > > Any chance we can get this applied for 5.15/stable? This fixes > runtime pm problems on GPU boards with integrated USB. > https://gitlab.freedesktop.org/drm/amd/-/issues/1704 Thanks for the link. It's always nice to have a clue about what problems a quirk fixes. I added the link to the commit log and moved the whole thing to for-linus for v5.15. > Thanks, > > Alex > > > > > > --- > > > drivers/pci/quirks.c | 9 +++++++-- > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index > > > dea10d62d5b9..f0c5dd3406a1 100644 > > > --- a/drivers/pci/quirks.c > > > +++ b/drivers/pci/quirks.c > > > @@ -5338,7 +5338,7 @@ > > DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, > > > PCI_CLASS_MULTIMEDIA_HD_AUDIO, 8, > > quirk_gpu_hda); > > > > > > /* > > > - * Create device link for NVIDIA GPU with integrated USB xHCI Host > > > + * Create device link for GPUs with integrated USB xHCI Host > > > * controller to VGA. > > > */ > > > static void quirk_gpu_usb(struct pci_dev *usb) @@ -5347,9 +5347,11 @@ > > > static void quirk_gpu_usb(struct pci_dev *usb) } > > > DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, > > PCI_ANY_ID, > > > PCI_CLASS_SERIAL_USB, 8, quirk_gpu_usb); > > > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID, > > > + PCI_CLASS_SERIAL_USB, 8, quirk_gpu_usb); > > > > > > /* > > > - * Create device link for NVIDIA GPU with integrated Type-C UCSI > > > controller > > > + * Create device link for GPUs with integrated Type-C UCSI controller > > > * to VGA. Currently there is no class code defined for UCSI device over PCI > > > * so using UNKNOWN class for now and it will be updated when UCSI > > > * over PCI gets a class code. > > > @@ -5362,6 +5364,9 @@ static void quirk_gpu_usb_typec_ucsi(struct > > > pci_dev *ucsi) > > DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, > > > PCI_CLASS_SERIAL_UNKNOWN, 8, > > > quirk_gpu_usb_typec_ucsi); > > > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID, > > > + PCI_CLASS_SERIAL_UNKNOWN, 8, > > > + quirk_gpu_usb_typec_ucsi); > > > > > > /* > > > * Enable the NVIDIA GPU integrated HDA controller if the BIOS left > > > it > > > -- > > > 2.29.0 > > >