From: "Krzysztof Wilczyński" <kw@linux.com>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: endpoint: Use sysfs_emit() in "show" functions
Date: Fri, 17 Sep 2021 00:43:48 +0200 [thread overview]
Message-ID: <20210916224348.GA1510593@rocinante> (raw)
In-Reply-To: <b9eb71b0-8328-fb05-3b8c-112cb8dbbda2@socionext.com>
Hayashi-san,
Thank you for sending this as separate patch.
> Gentle ping, are there any comments?
I am sure Bjorn or Lorenzo will get to this patch soon, it's still marked
as "New" in patchwork, as per:
https://patchwork.kernel.org/project/linux-pci/patch/1630472957-26857-1-git-send-email-hayashi.kunihiko@socionext.com/
My "Reviewed-by" still applies, of course.
[...]
> > Convert sprintf() in sysfs "show" functions to sysfs_emit() in order to
> > check for buffer overruns in sysfs outputs.
As Bjorn, or someone else might ask, you could add a short note about this
being configfs, rather than sysfs, and that sysfs_emit() will still work.
Something as per what I said while commenting on the previous patch:
https://lore.kernel.org/all/20210719034313.GA274232@rocinante/
Krzysztof
next prev parent reply other threads:[~2021-09-16 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 5:09 [PATCH v2] PCI: endpoint: Use sysfs_emit() in "show" functions Kunihiko Hayashi
2021-09-16 11:30 ` Kunihiko Hayashi
2021-09-16 22:43 ` Krzysztof Wilczyński [this message]
2021-09-30 11:05 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916224348.GA1510593@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).