From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Arnd Bergmann <arnd@kernel.org>,
bhelgaas@google.com, marek.vasut+renesas@gmail.com,
sboyd@kernel.org
Cc: "Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar: add COMMON_CLK dependency
Date: Mon, 20 Sep 2021 11:09:27 +0100 [thread overview]
Message-ID: <20210920100927.GA9284@lpieralisi> (raw)
In-Reply-To: <20210920095730.1216692-1-arnd@kernel.org>
On Mon, Sep 20, 2021 at 11:57:10AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The __clk_is_enabled() interface is only available when building for
> platforms using CONFIG_COMMON_CLK:
>
> arm-linux-gnueabi-ld: drivers/pci/controller/pcie-rcar-host.o: in function `rcar_pcie_aarch32_abort_handler':
> pcie-rcar-host.c:(.text+0x8fc): undefined reference to `__clk_is_enabled'
>
> Add the necessary dependency to the COMPILE_TEST path.
>
> Fixes: a115b1bd3af0 ("PCI: rcar: Add L1 link state fix into data abort hook")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Marek already posted a fix for this:
https://lore.kernel.org/linux-pci/20210907144512.5238-1-marek.vasut@gmail.com
and was waiting for Stephen to have a look to determine if this
could be simplified (Arnd patch already does, btw).
We should merge a fix for this asap.
Lorenzo
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 326f7d13024f..53e3648fe872 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -65,7 +65,7 @@ config PCI_RCAR_GEN2
>
> config PCIE_RCAR_HOST
> bool "Renesas R-Car PCIe host controller"
> - depends on ARCH_RENESAS || COMPILE_TEST
> + depends on ARCH_RENESAS || (COMMON_CLK && COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> help
> Say Y here if you want PCIe controller support on R-Car SoCs in host
> --
> 2.29.2
>
prev parent reply other threads:[~2021-09-20 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 9:57 [PATCH] PCI: rcar: add COMMON_CLK dependency Arnd Bergmann
2021-09-20 10:09 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920100927.GA9284@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).