From: Bjorn Helgaas <helgaas@kernel.org>
To: Pranay Sanghai <pranaysanghai@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/pci/setup-irq.c: Fix up comments.
Date: Tue, 28 Sep 2021 13:47:23 -0500 [thread overview]
Message-ID: <20210928184723.GA717133@bhelgaas> (raw)
In-Reply-To: <YUZJenW2UCA4Qu0O@pranay-desktop>
On Sat, Sep 18, 2021 at 01:18:02PM -0700, Pranay Sanghai wrote:
> Make comments follow multi-line comment conventions. No functional change intended.
>
> Signed-off-by: Pranay Sanghai <pranaysanghai@gmail.com>
Applied to pci/misc for v5.16, with the changes below, thanks!
- Updated subject line to follow the convention (see "git log
--oneline drivers/pci/setup-irq.c").
- Rewrapped commit log to fit in 75 columns so it fits in 80 when
"git log" indents it.
- Rewrapped comments to fill 80 columns like the rest of the file.
- Replaced "'cos" with "because".
> ---
> drivers/pci/setup-irq.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
> index 7129494754dd..ed628771250b 100644
> --- a/drivers/pci/setup-irq.c
> +++ b/drivers/pci/setup-irq.c
> @@ -28,12 +28,13 @@ void pci_assign_irq(struct pci_dev *dev)
> return;
> }
>
> - /* If this device is not on the primary bus, we need to figure out
> - which interrupt pin it will come in on. We know which slot it
> - will come in on 'cos that slot is where the bridge is. Each
> - time the interrupt line passes through a PCI-PCI bridge we must
> - apply the swizzle function. */
> -
> + /*
> + * If this device is not on the primary bus, we need to figure out
> + * which interrupt pin it will come in on. We know which slot it
> + * will come in on 'cos that slot is where the bridge is. Each
> + * time the interrupt line passes through a PCI-PCI bridge we must
> + * apply the swizzle function.
> + */
> pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
> /* Cope with illegal. */
> if (pin > 4)
> @@ -56,7 +57,9 @@ void pci_assign_irq(struct pci_dev *dev)
>
> pci_dbg(dev, "assign IRQ: got %d\n", dev->irq);
>
> - /* Always tell the device, so the driver knows what is
> - the real IRQ to use; the device does not use it. */
> + /*
> + * Always tell the device, so the driver knows what is
> + * the real IRQ to use; the device does not use it.
> + */
> pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
> }
> --
> 2.33.0
>
prev parent reply other threads:[~2021-09-28 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 20:18 [PATCH] drivers/pci/setup-irq.c: Fix up comments Pranay Sanghai
2021-09-28 18:47 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928184723.GA717133@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pranaysanghai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).