From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Marek Vasut <marek.vasut@gmail.com>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-pci <linux-pci@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] PCI: rcar: Add missing COMMON_CLK dependency
Date: Wed, 29 Sep 2021 15:55:09 +0100 [thread overview]
Message-ID: <20210929145509.GA20495@lpieralisi> (raw)
In-Reply-To: <d720b758-109a-434e-b1a4-f49649dd34e9@gmail.com>
On Wed, Sep 22, 2021 at 01:13:11AM +0200, Marek Vasut wrote:
> On 9/21/21 6:08 PM, Geert Uytterhoeven wrote:
>
> [...]
>
> > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > > index 326f7d13024f..ee6f5e525d3a 100644
> > > --- a/drivers/pci/controller/Kconfig
> > > +++ b/drivers/pci/controller/Kconfig
> > > @@ -66,6 +66,7 @@ config PCI_RCAR_GEN2
> > > config PCIE_RCAR_HOST
> > > bool "Renesas R-Car PCIe host controller"
> > > depends on ARCH_RENESAS || COMPILE_TEST
> > > + depends on COMMON_CLK
> >
> > This part is OK.
>
> This part is also identical in the patch from Arnd, so you can just pick
> that one as a fix and be done with it:
>
> [PATCH] PCI: rcar: add COMMON_CLK dependency
> https://patchwork.kernel.org/project/linux-pci/patch/20210920095730.1216692-1-arnd@kernel.org/
It is not strictly identical (Arnd's patch only touches the COMPILE_TEST
option).
Bjorn, shall we pick Arnd's patch up then ? We should be fixing this in
one of the upcoming -rcs since we introduced it in the last merge
window.
Thanks,
Lorenzo
next prev parent reply other threads:[~2021-09-29 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 14:45 [PATCH] PCI: rcar: Add missing COMMON_CLK dependency marek.vasut
2021-09-13 12:39 ` Lorenzo Pieralisi
2021-09-21 16:08 ` Geert Uytterhoeven
2021-09-21 23:13 ` Marek Vasut
2021-09-29 14:55 ` Lorenzo Pieralisi [this message]
2021-09-29 16:32 ` Bjorn Helgaas
2021-09-29 18:55 ` Arnd Bergmann
2021-09-29 19:08 ` Geert Uytterhoeven
2021-09-29 19:11 ` Bjorn Helgaas
2021-09-30 5:30 ` Stephen Boyd
2021-09-30 8:01 ` Geert Uytterhoeven
2021-09-30 18:16 ` Stephen Boyd
2021-09-30 18:31 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929145509.GA20495@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=sboyd@kernel.org \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).