From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3457C433EF for ; Thu, 30 Sep 2021 15:21:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA3B661A0D for ; Thu, 30 Sep 2021 15:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245737AbhI3PW5 (ORCPT ); Thu, 30 Sep 2021 11:22:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:59301 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343496AbhI3PW4 (ORCPT ); Thu, 30 Sep 2021 11:22:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633015273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0abga0D1u/IdQg9y3krLjrNSALXarJfiwXawsFlevdE=; b=MWIly+XI80iABTLWGrYKxS37oR9RsoGLV1eA2VgcEK5W9DiRayQV/bfKkm1Q4XFxyHF6/j 76TMyPmZ7Qy6K9XARzIJ5XGSErTE2cFs7niKM/vPonvBpJgut8nmpF1ng879w2Wzt27vFw 1pMD4/jGptSDuh+lnJFje75ZTQ10y8A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-bzsF4HDaNp6pQ-PhZlJliQ-1; Thu, 30 Sep 2021 11:21:06 -0400 X-MC-Unique: bzsF4HDaNp6pQ-PhZlJliQ-1 Received: by mail-wr1-f71.google.com with SMTP id r16-20020adfbb10000000b00160958ed8acso38387wrg.16 for ; Thu, 30 Sep 2021 08:21:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0abga0D1u/IdQg9y3krLjrNSALXarJfiwXawsFlevdE=; b=5J76j9Ym6rtHlwmQMTeMMon1FbQigVhzM8k63ayyuf45YZVuH7Sa8VO6lUossWldkd 8mJKYu4edEVaeSGjhxQqJxpgAJbmfxZefhHo942vwPLVXfkAPENXjSP0GmKUpQNhefeL O1TiylKhYS41oMNjmo85PpA/JiHXtY5oJKM41229UErkBkfQ/gnL2J7TFnlZYOWbobfT DvasL1y0GZcUToDs0LCVXIi8tfI8p/tSV86OC+yK34X9alaz+4aTDef/ovFpm4YS07wk qC+Z8al+qIvGmNv4PWbGTf7yL3lxcM0oXGSeQDT2pwWlgf5vgQ9feE8QGeG8hETqlG07 xwsQ== X-Gm-Message-State: AOAM532+u0ehl0F5NkN5d0GTgq6I/FIRhJ7g5/neKTR4GynnOnGVcrCW NCW2lZ5N49nxHbgJVFVFEPaO1/hMnnlQJTV+z32/U3JBE4o81mIeGXXtJLiiMHhHTisivOFUAGk lQimUkjRimWdL2nWKJ9Rw X-Received: by 2002:adf:8b47:: with SMTP id v7mr6750088wra.321.1633015261067; Thu, 30 Sep 2021 08:21:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyixcUuc+JnWbDfw8P1vGJjmgwF6F7FsHdgfu/4LhDBVO7PYY7/qogrpldeQ6XDAuFJuHmFBA== X-Received: by 2002:adf:8b47:: with SMTP id v7mr6749726wra.321.1633015257068; Thu, 30 Sep 2021 08:20:57 -0700 (PDT) Received: from redhat.com ([2.55.134.220]) by smtp.gmail.com with ESMTPSA id z79sm3332530wmc.17.2021.09.30.08.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 08:20:56 -0700 (PDT) Date: Thu, 30 Sep 2021 11:20:52 -0400 From: "Michael S. Tsirkin" To: "Kuppuswamy, Sathyanarayanan" Cc: Dan Williams , Greg Kroah-Hartman , Borislav Petkov , X86 ML , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Andreas Noever , Michael Jamet , Yehezkel Bernat , "Rafael J . Wysocki" , Mika Westerberg , Jonathan Corbet , Jason Wang , Andi Kleen , Kuppuswamy Sathyanarayanan , Linux Kernel Mailing List , Linux PCI , USB list , virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest Message-ID: <20210930112029-mutt-send-email-mst@kernel.org> References: <20210930010511.3387967-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930010511.3387967-5-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930065953-mutt-send-email-mst@kernel.org> <6d1e2701-5095-d110-3b0a-2697abd0c489@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d1e2701-5095-d110-3b0a-2697abd0c489@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Sep 30, 2021 at 08:18:18AM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > On 9/30/21 6:36 AM, Dan Williams wrote: > > > And in particular, not all virtio drivers are hardened - > > > I think at this point blk and scsi drivers have been hardened - so > > > treating them all the same looks wrong. > > My understanding was that they have been audited, Sathya? > > Yes, AFAIK, it has been audited. Andi also submitted some patches > related to it. Andi, can you confirm. > > We also authorize the virtio at PCI ID level. And currently we allow > console, block and net virtio PCI devices. > > { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO_TRANS_ID_NET) }, > { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO_TRANS_ID_BLOCK) }, > { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO_TRANS_ID_CONSOLE) }, Presumably modern IDs should be allowed too? -- MST