From: Pavel Machek <pavel@ucw.cz>
To: Dan Williams <dan.j.williams@intel.com>
Cc: stuart hayes <stuart.w.hayes@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"lukas@wunner.de" <lukas@wunner.de>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
mariusz.tkaczyk@linux.intel.com
Subject: Re: [PATCH v3] Add support for PCIe SSD status LED management
Date: Thu, 7 Oct 2021 10:24:10 +0200 [thread overview]
Message-ID: <20211007082410.GA15698@duo.ucw.cz> (raw)
In-Reply-To: <CAPcyv4iig5rxCNb7GyGV9akhZKLF+OeGhewSbOeAzzA6pKreRA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
Hi!
> > Thank you for the comments, Dan.
> >
> > I originally did submit something simple that just added a couple of
> > sysfs attributes to allow userspace access to the _DSM, but Greg K-H
> > said (1) that I shouldn't create new driver-specific sysfs files that do
> > things that existing class drivers do, and that if I'm allowing LEDs to
> > be controlled by the user, I have to use the LED subsystem, so I went
> > with that. (See the end of
> > https://patchwork.ozlabs.org/project/linux-pci/patch/20201110153735.58587-1-stuart.w.hayes@gmail.com/)
>
> I agree with the general sentiment to adopt and extend existing ABIs
> wherever possible, it's just not clear to me that the LED class driver
> is the best fit. The Enclosure class infrastructure, in addition to
LED drivers are not good fit for this. It is unlikely to be accepted.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-10-07 8:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 21:36 [PATCH v3] Add support for PCIe SSD status LED management Stuart Hayes
2021-08-14 6:23 ` Lukas Wunner
2021-10-04 17:41 ` stuart hayes
2021-10-05 4:41 ` Williams, Dan J
2021-08-18 7:05 ` Pavel Machek
2021-10-04 18:04 ` stuart hayes
2021-10-05 5:14 ` Williams, Dan J
2021-10-06 2:42 ` stuart hayes
2021-10-06 20:15 ` Dan Williams
2021-10-07 8:24 ` Pavel Machek [this message]
2021-10-07 11:32 ` Tkaczyk, Mariusz
2021-11-02 16:23 ` stuart hayes
2021-11-06 2:52 ` Dan Williams
2021-11-07 14:40 ` James Bottomley
2021-11-12 0:56 ` Krzysztof Wilczyński
2021-11-25 22:13 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007082410.GA15698@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=kw@linux.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).