From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: cpqphp: Format if-statement code block correctly
Date: Tue, 12 Oct 2021 20:50:41 -0500 [thread overview]
Message-ID: <20211013015041.GA1862613@bhelgaas> (raw)
In-Reply-To: <20211013011412.1110829-1-kw@linux.com>
On Wed, Oct 13, 2021 at 01:14:12AM +0000, Krzysztof Wilczyński wrote:
> The if-statement code block as seen in the cpqhp_s
>
> The code block related to the if-statement in cpqhp_set_irq() is
> somewhat awkwardly formatted making the code hard to read.
>
> Thus, update the code to match preferred code formatting style.
>
> No change to functionality intended.
>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---
> drivers/pci/hotplug/cpqphp_pci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied with the commit log touchup to pci/misc for v5.16, thanks!
Looks like somebody's "J" key got stuck in vi :)
> diff --git a/drivers/pci/hotplug/cpqphp_pci.c b/drivers/pci/hotplug/cpqphp_pci.c
> index 1b2b3f3b648b..9038039ad6db 100644
> --- a/drivers/pci/hotplug/cpqphp_pci.c
> +++ b/drivers/pci/hotplug/cpqphp_pci.c
> @@ -189,8 +189,10 @@ int cpqhp_set_irq(u8 bus_num, u8 dev_num, u8 int_pin, u8 irq_num)
> /* This should only be for x86 as it sets the Edge Level
> * Control Register
> */
> - outb((u8) (temp_word & 0xFF), 0x4d0); outb((u8) ((temp_word &
> - 0xFF00) >> 8), 0x4d1); rc = 0; }
> + outb((u8)(temp_word & 0xFF), 0x4d0);
> + outb((u8)((temp_word & 0xFF00) >> 8), 0x4d1);
> + rc = 0;
> + }
>
> return rc;
> }
> --
> 2.33.0
>
prev parent reply other threads:[~2021-10-13 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 1:14 [PATCH] PCI: cpqphp: Format if-statement code block correctly Krzysztof Wilczyński
2021-10-13 1:27 ` Krzysztof Wilczyński
2021-10-13 1:50 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013015041.GA1862613@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox