From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A77C4332F for ; Fri, 15 Oct 2021 06:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DA5961184 for ; Fri, 15 Oct 2021 06:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235799AbhJOG7e (ORCPT ); Fri, 15 Oct 2021 02:59:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24327 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235794AbhJOG7e (ORCPT ); Fri, 15 Oct 2021 02:59:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634281048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XrPIV2fprNlCi1MFN3D9uad/uIU7Ev00FM5PU9k9D8g=; b=GwGEbBaFXzzU9REDj1BMs3OjLs1HY0aJfHc/a+BJs6vuO0yix4OQclcAkiHiv1kYUhz722 xAFnGbVhG5my5OxhrPr3N3g1lTb8X+zidtpCKY67Q5trfQw/4cSbUyo/+jWUMFt9aJnieF CKM+HW1fLTN7z2tsVptUIFJFqhBauno= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-VC9-iisYNr6UjPOKOxomVQ-1; Fri, 15 Oct 2021 02:57:26 -0400 X-MC-Unique: VC9-iisYNr6UjPOKOxomVQ-1 Received: by mail-ed1-f71.google.com with SMTP id p20-20020a50cd94000000b003db23619472so7351550edi.19 for ; Thu, 14 Oct 2021 23:57:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XrPIV2fprNlCi1MFN3D9uad/uIU7Ev00FM5PU9k9D8g=; b=3yhBg1+LoGtgebz2rjyy8TG3x5sQ4sfBGQJn63LjSUb+II0cJI3Ry6/rcszo7Z5DAN 0YUvplDZbTZU5GsGTMA3iJ2WHf9AOrbyXcPfW6rq/et3KEBSciiZfgnZ1oAOWtotsFdI y9SVO+OT8er03sKijcKtADFumeDP1gHi0q0rZ1JNDy9z0mKoxDcK7PWkMSwyeyD7ZVIf 0dmx2OZpl66b9MI6EdnOCUa7BbPYiqVNLeGH+7reL5Kfa6XsLU5JIhM5W+8DcURasSs6 N402VJZsnL33ByjVV5L67mnlztj5qHP08Q0x96xhYC0Fn2h0rHhoKd/3UPwLzjssFWlD g22A== X-Gm-Message-State: AOAM531Vhz2oBWufHa0BzUJl41WMDY2k1xreAPuZOuzv0UeHHwtzqdSa OITstvmpT97Fc+1fCDFx5e64+lNrhMLYYMoHrNoMGZP310kisqji5c9GDahOG6HuoPpVRmEn5a3 BiG1ALbWfYBgg6UMyRlIm X-Received: by 2002:a05:6402:447:: with SMTP id p7mr15322762edw.261.1634281045400; Thu, 14 Oct 2021 23:57:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3wsrR7axiFHmfph2bLnxYqxO8ciYC1BIDrnzojSmvwa6tk0pkkVI5pGdF1DtDsbmx8LCmYQ== X-Received: by 2002:a05:6402:447:: with SMTP id p7mr15322726edw.261.1634281045218; Thu, 14 Oct 2021 23:57:25 -0700 (PDT) Received: from redhat.com ([2.55.1.196]) by smtp.gmail.com with ESMTPSA id e11sm4094212edl.70.2021.10.14.23.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 23:57:24 -0700 (PDT) Date: Fri, 15 Oct 2021 02:57:16 -0400 From: "Michael S. Tsirkin" To: Andi Kleen Cc: Kuppuswamy Sathyanarayanan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , Bjorn Helgaas , Richard Henderson , Thomas Bogendoerfer , James E J Bottomley , Helge Deller , "David S . Miller" , Arnd Bergmann , Jonathan Corbet , Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Josh Poimboeuf , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v5 16/16] x86/tdx: Add cmdline option to force use of ioremap_host_shared Message-ID: <20211015024923-mutt-send-email-mst@kernel.org> References: <20211009070132-mutt-send-email-mst@kernel.org> <8c906de6-5efa-b87a-c800-6f07b98339d0@linux.intel.com> <20211011075945-mutt-send-email-mst@kernel.org> <9d0ac556-6a06-0f2e-c4ff-0c3ce742a382@linux.intel.com> <20211011142330-mutt-send-email-mst@kernel.org> <4fe8d60a-2522-f111-995c-dcbefd0d5e31@linux.intel.com> <20211012165705-mutt-send-email-mst@kernel.org> <20211012171846-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Oct 14, 2021 at 10:50:59PM -0700, Andi Kleen wrote: > > > I thought you basically create an OperationRegion of SystemMemory type, > > and off you go. Maybe the OSPM in Linux is clever and protects > > some memory, I wouldn't know. > > > I investigated this now, and it looks like acpi is using ioremap_cache(). We > can hook into that and force non sharing. It's probably safe to assume that > this is not used on real IO devices. > > I think there are still some other BIOS mappings that use just plain > ioremap() though. > > > -Andi Hmm don't you mean the reverse? If you make ioremap shared then OS is protected from malicious ACPI? If you don't make it shared then malicious ACPI can poke at arbitrary OS memory. Looks like making ioremap non shared by default is actually less safe than shared. Interesting. For BIOS I suspect there's no way around it, it needs to be audited since it's executable. -- MST