* [PATCH] x86/PCI: Fix compile errors when CONFIG_PCI is disabled
@ 2021-10-20 10:21 Hans de Goede
2021-10-25 9:50 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2021-10-20 10:21 UTC (permalink / raw)
To: Rafael J . Wysocki, Mika Westerberg, Krzysztof Wilczyński,
Bjorn Helgaas, Myron Stowe, Juha-Pekka Heikkila, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, H . Peter Anvin
Cc: Hans de Goede, linux-acpi, linux-pci, x86, linux-kernel,
kernel test robot
arch/x86/include/asm/pci_x86.h uses a number of data -types and defines
without including the headers which define these.
Instead so far it has been relying on files including it including the
necessary headers first.
Recently a include <asm/pci_x86.h> was added to arch/x86/kernel/resource.c
which does not include the necessary headers first.
Add the missing includes to arch/x86/include/asm/pci_x86.h to fix the
compile errors (with certain .config-s) when it is included from
arch/x86/kernel/resource.c.
Fixes: f10507a66e36 ("x86/PCI: Ignore E820 reservations for bridge windows on newer systems")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
arch/x86/include/asm/pci_x86.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h
index 0bb4e7dd0ffc..c5413d8007ed 100644
--- a/arch/x86/include/asm/pci_x86.h
+++ b/arch/x86/include/asm/pci_x86.h
@@ -5,7 +5,10 @@
* (c) 1999 Martin Mares <mj@ucw.cz>
*/
+#include <linux/errno.h>
+#include <linux/init.h>
#include <linux/ioport.h>
+#include <linux/spinlock.h>
#undef DEBUG
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] x86/PCI: Fix compile errors when CONFIG_PCI is disabled
2021-10-20 10:21 [PATCH] x86/PCI: Fix compile errors when CONFIG_PCI is disabled Hans de Goede
@ 2021-10-25 9:50 ` Mika Westerberg
2021-10-25 10:02 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2021-10-25 9:50 UTC (permalink / raw)
To: Hans de Goede
Cc: Rafael J . Wysocki, Krzysztof Wilczyński, Bjorn Helgaas,
Myron Stowe, Juha-Pekka Heikkila, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H . Peter Anvin, linux-acpi, linux-pci, x86,
linux-kernel, kernel test robot
On Wed, Oct 20, 2021 at 12:21:02PM +0200, Hans de Goede wrote:
> arch/x86/include/asm/pci_x86.h uses a number of data -types and defines
> without including the headers which define these.
>
> Instead so far it has been relying on files including it including the
> necessary headers first.
>
> Recently a include <asm/pci_x86.h> was added to arch/x86/kernel/resource.c
> which does not include the necessary headers first.
>
> Add the missing includes to arch/x86/include/asm/pci_x86.h to fix the
> compile errors (with certain .config-s) when it is included from
> arch/x86/kernel/resource.c.
>
> Fixes: f10507a66e36 ("x86/PCI: Ignore E820 reservations for bridge windows on newer systems")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/PCI: Fix compile errors when CONFIG_PCI is disabled
2021-10-25 9:50 ` Mika Westerberg
@ 2021-10-25 10:02 ` Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2021-10-25 10:02 UTC (permalink / raw)
To: Mika Westerberg
Cc: Hans de Goede, Rafael J . Wysocki, Krzysztof Wilczyński,
Bjorn Helgaas, Myron Stowe, Juha-Pekka Heikkila, Thomas Gleixner,
Ingo Molnar, H . Peter Anvin, linux-acpi, linux-pci, x86,
linux-kernel, kernel test robot
On Mon, Oct 25, 2021 at 12:50:19PM +0300, Mika Westerberg wrote:
> On Wed, Oct 20, 2021 at 12:21:02PM +0200, Hans de Goede wrote:
> > arch/x86/include/asm/pci_x86.h uses a number of data -types and defines
> > without including the headers which define these.
> >
> > Instead so far it has been relying on files including it including the
> > necessary headers first.
> >
> > Recently a include <asm/pci_x86.h> was added to arch/x86/kernel/resource.c
> > which does not include the necessary headers first.
> >
> > Add the missing includes to arch/x86/include/asm/pci_x86.h to fix the
> > compile errors (with certain .config-s) when it is included from
> > arch/x86/kernel/resource.c.
> >
> > Fixes: f10507a66e36 ("x86/PCI: Ignore E820 reservations for bridge windows on newer systems")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
IIRC, this was squashed into the Fixes: patch:
https://lore.kernel.org/r/20211020211455.GA2641031@bhelgaas
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20 10:21 [PATCH] x86/PCI: Fix compile errors when CONFIG_PCI is disabled Hans de Goede
2021-10-25 9:50 ` Mika Westerberg
2021-10-25 10:02 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).