From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3BBC433EF for ; Thu, 21 Oct 2021 01:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADBC161186 for ; Thu, 21 Oct 2021 01:40:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbhJUBmq (ORCPT ); Wed, 20 Oct 2021 21:42:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:58888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbhJUBmp (ORCPT ); Wed, 20 Oct 2021 21:42:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8A5E2610A3; Thu, 21 Oct 2021 01:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634780430; bh=EUralENv330ewn9XRHZ1BpnRh5NsqZGkLbfXk4z3Pp4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Gwao20C+ItQvfrCBBPmm3C7nTwca5rnymIgfSohDSW6Pc4PPCRFrYTr436hrKPK1z aMhokgwHFzO+bAKE/Ts92ViYsQRHRUMq8twvA1r0ojQyXEf0FtjLlLsHUVFsL4k9PA WT/vW7LD6FQEI8OGTSWU/FqPEQFUd0hKkAx2u1zLU7/4Y07jgIFzZScMfWgwZp+a/F sjLQ5xwSZIrzPzbryfd0scaNOoGG1hCwjDxSZCPbCM+pFhsRILPQEcdi3Brop4gelq d4Msy2g3KmodJnhCtUHDoJlkw3SlMfICN4vjz+sXoXtHkOCi0P8whDMQv5M+qDJ/NT 4C8ff3ITwinOw== Date: Wed, 20 Oct 2021 20:40:29 -0500 From: Bjorn Helgaas To: Naveen Naidu Cc: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v4 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() Message-ID: <20211021014029.GA2657684@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Oct 05, 2021 at 10:48:11PM +0530, Naveen Naidu wrote: > dpc_process_error() clears both AER fatal and non fatal status > registers. Instead of clearing each status registers via a different > function call use pci_aer_clear_status(). > > This helps clean up the code a bit. > > Signed-off-by: Naveen Naidu > --- > drivers/pci/pcie/dpc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c > index df3f3a10f8bc..faf4a1e77fab 100644 > --- a/drivers/pci/pcie/dpc.c > +++ b/drivers/pci/pcie/dpc.c > @@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev) > dpc_get_aer_uncorrect_severity(pdev, &info) && > aer_get_device_error_info(pdev, &info)) { > aer_print_error(pdev, &info); > - pci_aer_clear_nonfatal_status(pdev); > - pci_aer_clear_fatal_status(pdev); > + pci_aer_clear_status(pdev); The commit log suggests that this is a simple cleanup that doesn't change any behavior, but that's not quite true: - The new code would clear PCI_ERR_ROOT_STATUS, but the old code does not. - The old code masks the status bits with the severity bits before clearing, but the new code does not. The commit log needs to show why these changes are what we want. > } > } > > -- > 2.25.1 > > _______________________________________________ > Linux-kernel-mentees mailing list > Linux-kernel-mentees@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees