From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC9DC433EF for ; Tue, 26 Oct 2021 22:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3FD361002 for ; Tue, 26 Oct 2021 22:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239905AbhJZWYO (ORCPT ); Tue, 26 Oct 2021 18:24:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:43722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235758AbhJZWYN (ORCPT ); Tue, 26 Oct 2021 18:24:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E2BAD60F02; Tue, 26 Oct 2021 22:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635286909; bh=Ti9ROmEWB++H0DVAD/4QLbK3bMpQv6DTgwhjoKZgM3Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PcI2FaCRlJY+KWzLUhYhOcAar43cbCPaiPFaGHtK9GQiTU5oUu5Cg99gBUjLkKFDY tsN2yWVZsuWG3Ldj/Eqxztu7tqHfh7OuGgEb9ljzY1EB3AiFARjrB2lR/PhwkmxHaY istohXv3cDHFL4Oz43TW05RJHlKH4+npN5TIF+kxSxOwART2KIjH3FajjF63TN3Iq5 7pIc3qIGTRh/KW7iiKIHsUTid1qRNbfxJJbd5S8tasOWHQ5fLcLUvwQp0l/7lM9KTV uxMaXqC+YxKabTJKA8IM7Q9sguYdy/4/br4qcOeCjOKvp2Tu/6EIjzwfrUpOtrvaV7 ghfJpn4scpUdg== Date: Tue, 26 Oct 2021 17:21:47 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "l.stach@pengutronix.de" , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "linux-pci@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up Message-ID: <20211026222147.GA173173@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Oct 25, 2021 at 02:35:36AM +0000, Richard Zhu wrote: > > -----Original Message----- > > From: Krzysztof Wilczyński > > Sent: Saturday, October 23, 2021 5:54 PM > > To: Richard Zhu > > Cc: Bjorn Helgaas ; l.stach@pengutronix.de; > > bhelgaas@google.com; lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; > > dl-linux-imx ; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de > > Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling > > unbalance when link never came up > > I hope you don't mind me asking, but how is an empty default case in the > > switch statement helping IMX6Q and IMX6QP? What does it achieve for > > these two controllers specifically? > > > [Richard Zhu] Never mind. 😊. > There might be following building warning if the "default:break" is removed. > " CC drivers/pci/controller/dwc/pci-imx6.o > drivers/pci/controller/dwc/pci-imx6.c: In function ‘imx6_pcie_clk_disable’: > drivers/pci/controller/dwc/pci-imx6.c:527:2: warning: enumeration value ‘IMX6Q’ not handled in switch [-Wswitch] > 527 | switch (imx6_pcie->drvdata->variant) { > | ^~~~~~ > drivers/pci/controller/dwc/pci-imx6.c:527:2: warning: enumeration value ‘IMX6QP’ not handled in switch [-Wswitch]" Sorry, I didn't see this until after asking the same question as Krzysztof. Sigh. That's a really annoying gcc warning, but I guess I won't fight it ;) Bjorn