From: Bjorn Helgaas <helgaas@kernel.org>
To: Dongdong Liu <liudongdong3@huawei.com>
Cc: hch@infradead.org, logang@deltatee.com, leon@kernel.org,
linux-pci@vger.kernel.org, rajur@chelsio.com,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH V11 7/8] PCI: Enable 10-Bit Tag support for PCIe Endpoint device
Date: Mon, 1 Nov 2021 17:33:14 -0500 [thread overview]
Message-ID: <20211101223314.GA557567@bhelgaas> (raw)
In-Reply-To: <20211101220239.GA554641@bhelgaas>
On Mon, Nov 01, 2021 at 05:02:41PM -0500, Bjorn Helgaas wrote:
> On Sat, Oct 30, 2021 at 09:53:47PM +0800, Dongdong Liu wrote:
> > 10-Bit Tag capability, introduced in PCIe-4.0 increases the total Tag
> > field size from 8 bits to 10 bits.
> >
> > PCIe spec 5.0 r1.0 section 2.2.6.2 "Considerations for Implementing
> > 10-Bit Tag Capabilities" Implementation Note:
> >
> > For platforms where the RC supports 10-Bit Tag Completer capability,
> > it is highly recommended for platform firmware or operating software
> > that configures PCIe hierarchies to Set the 10-Bit Tag Requester Enable
> > bit automatically in Endpoints with 10-Bit Tag Requester capability.
> > This enables the important class of 10-Bit Tag capable adapters that
> > send Memory Read Requests only to host memory.
> >
> > It's safe to enable 10-bit tags for all devices below a Root Port that
> > supports them. Switches that lack 10-Bit Tag Completer capability are
> > still able to forward NPRs and Completions carrying 10-Bit Tags correctly,
> > since the two new Tag bits are in TLP Header bits that were formerly
> > Reserved.
>
> Side note: the reason we want to do this to increase performance by
> allowing more outstanding requests. Do you have any benchmarking that
> we can mention here to show that this is actually a benefit? I don't
> doubt that it is, but I assume you've measured it and it would be nice
> to advertise it.
Hmmm. I did a quick Google search looking for "nvme pcie 10-bit tags"
hoping to find some performance info, but what I *actually* found was
several reports of 10-bit tags causing breakage:
https://www.reddit.com/r/MSI_Gaming/comments/exjvzg/x570_apro_7c37vh72beta_version_has_anyone_tryed_it/
https://rog.asus.com/forum/showthread.php?115064-Beware-of-agesa-1-0-0-4B-bios-not-good!/page2
https://forum-en.msi.com/index.php?threads/sound-blaster-z-has-weird-behaviour-after-updating-bios-x570-gaming-edge-wifi.325223/page-2
https://gearspace.com/board/electronic-music-instruments-and-electronic-music-production/1317189-h8000fw-firewire-facts-2020-must-read.html
https://www.soundonsound.com/forum/viewtopic.php?t=69651&start=12
https://forum.rme-audio.de/viewtopic.php?id=30307
This is a big problem for me.
Some of these might be a broken BIOS that turns on 10-bit tags when
the completer doesn't support them. I didn't try to debug them to
that level. But the last thing I want is to enable 10-bit by default
and cause boot issues or sound card issues or whatever.
I'm pretty sure this is a show-stopper for wedging this into v5.16 at
this late date. It's conceivable we could still do it if everything
defaulted to "off" and we had a knob whereby users could turn it on
via boot param or sysfs.
In any case, we (by which I'm afraid I mean "you" :)) need to
investigate the problem reports, figure out whether we will see
similar problems, and fix them before merging if we can.
Thanks to Krzysztof for pointing out the potential for issues like
this.
Bjorn
next prev parent reply other threads:[~2021-11-01 22:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 13:53 [PATCH V11 0/8] PCI: Enable 10-Bit tag support for PCIe devices Dongdong Liu
2021-10-30 13:53 ` [PATCH V11 1/8] PCI: Use cached devcap in more places Dongdong Liu
2021-10-30 13:53 ` [PATCH V11 2/8] PCI: Cache Device Capabilities 2 Register Dongdong Liu
2021-10-30 13:53 ` [PATCH V11 3/8] PCI: Add 10-Bit Tag register definitions Dongdong Liu
2021-10-30 13:53 ` [PATCH V11 4/8] PCI/sysfs: Add a tags sysfs file for PCIe Endpoint devices Dongdong Liu
2021-11-01 20:54 ` Bjorn Helgaas
2021-11-02 13:03 ` Dongdong Liu
2021-10-30 13:53 ` [PATCH V11 5/8] PCI/IOV: Add tags sysfs files for VF devices Dongdong Liu
2021-10-30 13:53 ` [PATCH V11 6/8] PCI/P2PDMA: Add a 10-Bit Tag check in P2PDMA Dongdong Liu
2021-10-30 13:53 ` [PATCH V11 7/8] PCI: Enable 10-Bit Tag support for PCIe Endpoint device Dongdong Liu
2021-11-01 22:02 ` Bjorn Helgaas
2021-11-01 22:33 ` Bjorn Helgaas [this message]
2021-11-03 10:05 ` Dongdong Liu
2021-11-03 16:02 ` Bjorn Helgaas
2021-11-05 8:24 ` Dongdong Liu
2021-11-05 17:39 ` Bjorn Helgaas
2021-10-30 13:53 ` [PATCH V11 8/8] PCI/IOV: Enable 10-Bit Tag support for PCIe VF devices Dongdong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101223314.GA557567@bhelgaas \
--to=helgaas@kernel.org \
--cc=hch@infradead.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=leon@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=logang@deltatee.com \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).