From: Marc Zyngier <maz@kernel.org>
To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rui Salvaterra <rsalvaterra@gmail.com>,
kernel-team@android.com
Subject: [PATCH 2/2] PCI: Add MSI masking quirk for Nvidia ION AHCI
Date: Thu, 4 Nov 2021 18:01:30 +0000 [thread overview]
Message-ID: <20211104180130.3825416-3-maz@kernel.org> (raw)
In-Reply-To: <20211104180130.3825416-1-maz@kernel.org>
The ION AHCI device pretends that MSI masking isn't a thing,
while it actually implements it and needs MSIs to be unmasked
to work. Add a quirk to that effect.
Reported-by: Rui Salvaterra <rsalvaterra@gmail.com>
Tested-by: Rui Salvaterra <rsalvaterra@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com
---
drivers/pci/quirks.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 4537d1ea14fd..89c7c99cd1bb 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5795,3 +5795,9 @@ static void apex_pci_fixup_class(struct pci_dev *pdev)
}
DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a,
PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class);
+
+static void nvidia_ion_ahci_fixup(struct pci_dev *pdev)
+{
+ pdev->dev_flags |= PCI_DEV_FLAGS_HAS_MSI_MASKING;
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0ab8, nvidia_ion_ahci_fixup);
--
2.30.2
next prev parent reply other threads:[~2021-11-04 18:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:01 [PATCH 0/2] PCI: MSI: Deal with devices lying about their masking capability Marc Zyngier
2021-11-04 18:01 ` [PATCH 1/2] PCI: MSI: Deal with devices lying about their MSI mask capability Marc Zyngier
2021-11-04 18:01 ` Marc Zyngier [this message]
2021-11-05 13:14 ` [PATCH 0/2] PCI: MSI: Deal with devices lying about their masking capability Thomas Gleixner
2021-11-16 10:21 ` Rui Salvaterra
2021-11-16 10:39 ` Greg KH
2021-11-16 10:47 ` Rui Salvaterra
2021-11-16 10:56 ` Greg KH
2021-11-19 14:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104180130.3825416-3-maz@kernel.org \
--to=maz@kernel.org \
--cc=bhelgaas@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox