public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>,
	Jianjun Wang <jianjun.wang@mediatek.com>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Fan Fei" <ffclaire1224@gmail.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Distinguish mediatek drivers
Date: Fri, 5 Nov 2021 15:29:13 -0500	[thread overview]
Message-ID: <20211105202913.GA944432@bhelgaas> (raw)

We have two MediaTek drivers: pcie-mediatek.c, which claims:

  .compatible = "mediatek,mt2701-pcie"
  .compatible = "mediatek,mt7623-pcie"
  .compatible = "mediatek,mt2712-pcie"
  .compatible = "mediatek,mt7622-pcie"
  .compatible = "mediatek,mt7629-pcie"

and pcie-mediatek-gen3.c, which claims:

  .compatible = "mediatek,mt8192-pcie"

The Kconfig text does not distinguish them.  Can somebody update these
entries so they do?  It's nice if we can mention model numbers or
product names that a user would recognize.

  config PCIE_MEDIATEK
        tristate "MediaTek PCIe controller"
        depends on ARCH_MEDIATEK || COMPILE_TEST
        depends on OF
        depends on PCI_MSI_IRQ_DOMAIN
        help
          Say Y here if you want to enable PCIe controller support on
          MediaTek SoCs.

  config PCIE_MEDIATEK_GEN3
        tristate "MediaTek Gen3 PCIe controller"
        depends on ARCH_MEDIATEK || COMPILE_TEST
        depends on PCI_MSI_IRQ_DOMAIN
        help
          Adds support for PCIe Gen3 MAC controller for MediaTek SoCs.
          This PCIe controller is compatible with Gen3, Gen2 and Gen1 speed,
          and support up to 256 MSI interrupt numbers for
          multi-function devices.

          Say Y here if you want to enable Gen3 PCIe controller support on
          MediaTek SoCs.

Both drivers are also named "mtk-pcie" and use the same internal
"mtk_" prefix on structs and functions.  Not a *huge* problem, but not
really ideal either.

Bjorn

             reply	other threads:[~2021-11-05 20:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 20:29 Bjorn Helgaas [this message]
2021-11-08  3:17 ` Distinguish mediatek drivers Jianjun Wang
2021-11-08 15:52   ` Krzysztof Wilczyński
2021-11-09  5:58     ` Jianjun Wang
2021-11-14  3:37       ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211105202913.GA944432@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=ffclaire1224@gmail.com \
    --cc=jianjun.wang@mediatek.com \
    --cc=kw@linux.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    --cc=ryder.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox