Re: [PATCH 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2752 bytes --]

Hi "David,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on v5.16-rc1 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211120-095959
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-buildonly-randconfig-r001-20211118 (attached as .config)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d0452407e2d5bf22bd1094654d7e868311b7c94e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211120-095959
        git checkout d0452407e2d5bf22bd1094654d7e868311b7c94e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/controller/vmd.c:676:5: warning: no previous prototype for function 'vmd_enable_aspm' [-Wmissing-prototypes]
   int vmd_enable_aspm(struct pci_dev *pdev, void *userdata)
       ^
   drivers/pci/controller/vmd.c:676:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int vmd_enable_aspm(struct pci_dev *pdev, void *userdata)
   ^
   static 
   1 warning generated.


vim +/vmd_enable_aspm +676 drivers/pci/controller/vmd.c

   671	
   672	/*
   673	 * Override the BIOS ASPM policy and set the LTR value for PCI storage
   674	 * devices on the VMD bride.
   675	 */
 > 676	int vmd_enable_aspm(struct pci_dev *pdev, void *userdata)
   677	{
   678		int features = *(int *)userdata;
   679	
   680		if (features & VMD_FEAT_QUIRK_OVERRIDE_ASPM &&
   681		    pdev->class == PCI_CLASS_STORAGE_EXPRESS) {
   682			int pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_LTR);
   683	
   684			if (pos) {
   685				pci_write_config_word(pdev, pos + PCI_LTR_MAX_SNOOP_LAT, 0x1003);
   686				pci_write_config_word(pdev, pos + PCI_LTR_MAX_NOSNOOP_LAT, 0x1003);
   687				pcie_aspm_policy_override(pdev);
   688			}
   689		}
   690		return 0;
   691	}
   692	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41769 bytes --]