Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

Lorenzo Pieralisi
2021-11-30T12:13:02Z

On Tue, Nov 30, 2021 at 11:59:32AM +0000, Marc Zyngier wrote:
> Hi Lorenzo, Bjorn,
>
> On 2021-11-30 11:56, Lorenzo Pieralisi wrote:
> > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> > > Apologies for the rapid fire (I tend to be much more conservative when
> > > resending series), but given that this series has a direct impact on
> > > other projects (such as u-boot), I'm trying to converge as quickly as
> > > possible.
> > >
> > > This series aims at fixing a number of issues for the recently merged
> > > Apple PCIe driver, all revolving around the mishandling of #PERST:
> > >
> > > - we didn't properly drive #PERST, and we didn't follow the specified
> > > timings
> > >
> > > - the DT had the wrong polarity, which has impacts on the driver
> > > itself
> > >
> > > Hopefully, this should address all the issues reported so far.
> > >
> > > * From v2:
> > > - Fixed DT
> > > - Fixed #PERST polarity in the driver
> > > - Collected Pali's ack on patch #1
> > >
> > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> > >
> > > Marc Zyngier (3):
> > > PCI: apple: Follow the PCIe specifications when resetting the port
> > > arm64: dts: apple: t8103: Fix PCIe #PERST polarity
> > > PCI: apple: Fix #PERST polarity
> > >
> > > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++---
> > > drivers/pci/controller/pcie-apple.c | 12 +++++++++++-
> > > 2 files changed, 15 insertions(+), 4 deletions(-)
> >
> > Hi Bjorn,
> >
> > this series is v5.16-rcX material for PCI fixes, can you pick patches
> > 1,3
> > up please ?
>
> Do you mind picking patch #2 as well? Or shall I route it somewhere else?

We were told that we should not pick up dts changes, they would normally
go via the ARM SOC team, not sure whether the fixes policy is different
though but I suspect that's not the case.

Thanks,
Lorenzo