Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

Bjorn Helgaas
2021-12-07T20:30:39Z

On Tue, Dec 07, 2021 at 10:16:32AM +0000, Lorenzo Pieralisi wrote:
> On Tue, Nov 30, 2021 at 11:56:32AM +0000, Lorenzo Pieralisi wrote:
> > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> > > Apologies for the rapid fire (I tend to be much more conservative when
> > > resending series), but given that this series has a direct impact on
> > > other projects (such as u-boot), I'm trying to converge as quickly as
> > > possible.
> > >
> > > This series aims at fixing a number of issues for the recently merged
> > > Apple PCIe driver, all revolving around the mishandling of #PERST:
> > >
> > > - we didn't properly drive #PERST, and we didn't follow the specified
> > > timings
> > >
> > > - the DT had the wrong polarity, which has impacts on the driver
> > > itself
> > >
> > > Hopefully, this should address all the issues reported so far.
> > >
> > > * From v2:
> > > - Fixed DT
> > > - Fixed #PERST polarity in the driver
> > > - Collected Pali's ack on patch #1
> > >
> > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> > >
> > > Marc Zyngier (3):
> > > PCI: apple: Follow the PCIe specifications when resetting the port
> > > arm64: dts: apple: t8103: Fix PCIe #PERST polarity
> > > PCI: apple: Fix #PERST polarity
> > >
> > > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++---
> > > drivers/pci/controller/pcie-apple.c | 12 +++++++++++-
> > > 2 files changed, 15 insertions(+), 4 deletions(-)
> >
> > Hi Bjorn,
> >
> > this series is v5.16-rcX material for PCI fixes, can you pick patches
> > 1,3 up please ?
>
> Hi Bjorn,
>
> Arnd acked patch 2, can we send the whole series upstream for one
> of the upcoming -rcX please ? It is fixing code that was merged
> in the last merge window.

I put all three of these on for-linus and will ask Linus to pull them
before -rc5.

I do have open questions about the PERST# timing, but we can update
this if needed.