From: "Marek Behún" <kabel@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org,
"Russell King" <linux@arm.linux.org.uk>,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Nadav Haklai" <nadavh@marvell.com>,
"Victor Gu" <xigu@marvell.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Zachary Zhang" <zhangzg@marvell.com>,
"Wilson Ding" <dingwei@marvell.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge
Date: Mon, 10 Jan 2022 03:21:27 +0100 [thread overview]
Message-ID: <20220110032127.4ea60dc9@thinkpad> (raw)
In-Reply-To: <20220107212736.GA404447@bhelgaas>
On Fri, 7 Jan 2022 15:27:36 -0600
Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote:
>
> > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie)
> > +{
> > + struct pci_sw_bridge *bridge = &pcie->bridge;
>
> > + /* Support interrupt A for MSI feature */
> > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE;
>
> Only 3.5 years later, IIUC, this is the value you get when you read
> PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not
> PCIE_CORE_INT_A_ASSERT_ENABLE.
>
> Readers expect to get the values defined in the PCI spec, i.e.,
>
> PCI_INTERRUPT_UNKNOWN
> PCI_INTERRUPT_INTA
> PCI_INTERRUPT_INTB
> PCI_INTERRUPT_INTC
> PCI_INTERRUPT_INTD
Hello Bjorn,
now sent v2 of batch 4 of fixes for pci-aardvark, where this is fixed
in the first patch.
https://lore.kernel.org/linux-pci/20220110015018.26359-1-kabel@kernel.org/
Could you find time to review the series? :-)
Marek
next prev parent reply other threads:[~2022-01-10 2:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 9:22 [PATCH 0/3] PCI: emulated PCI bridge common logic Thomas Petazzoni
2018-06-29 9:22 ` [PATCH 1/3] PCI: Introduce PCI software " Thomas Petazzoni
2018-07-12 19:58 ` Bjorn Helgaas
2018-08-01 8:49 ` Thomas Petazzoni
2018-08-01 9:21 ` Russell King - ARM Linux
2018-08-01 9:37 ` Thomas Petazzoni
2018-08-01 9:54 ` Thomas Petazzoni
2018-08-01 11:13 ` Thomas Petazzoni
2018-06-29 9:22 ` [PATCH 2/3] PCI: mvebu: Convert to PCI software bridge Thomas Petazzoni
2018-06-29 9:22 ` [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Thomas Petazzoni
2022-01-07 21:27 ` Bjorn Helgaas
2022-01-07 23:17 ` Bjorn Helgaas
2022-01-10 9:17 ` Pali Rohár
2022-01-10 2:21 ` Marek Behún [this message]
2018-07-12 9:24 ` [PATCH 0/3] PCI: emulated PCI bridge common logic Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220110032127.4ea60dc9@thinkpad \
--to=kabel@kernel.org \
--cc=antoine.tenart@bootlin.com \
--cc=bhelgaas@google.com \
--cc=dingwei@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=xigu@marvell.com \
--cc=zhangzg@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).