From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-pci@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH resend v2] PCI: pciehp: Use down_read/write_nested(reset_lock) to fix lockdep errors
Date: Wed, 12 Jan 2022 09:28:01 +0100 [thread overview]
Message-ID: <20220112082801.GA19022@wunner.de> (raw)
In-Reply-To: <20220111171447.GA152379@bhelgaas>
On Tue, Jan 11, 2022 at 11:14:47AM -0600, Bjorn Helgaas wrote:
> On Fri, Dec 17, 2021 at 03:17:09PM +0100, Hans de Goede wrote:
> > Use down_read_nested() and down_write_nested() when taking the
> > ctrl->reset_lock rw-sem, passing the number of PCIe hotplug controllers in
> > the path to the PCI root bus as lock subclass parameter. This fixes the
> > following false-positive lockdep report when unplugging a Lenovo X1C8 from
> > a Lenovo 2nd gen TB3 dock:
[...]
> Applied to pci/hotplug for v5.17, thanks, Hans!
I've realized only now that Hans reported this issue already in August 2020
and opened a bugzilla for it:
https://bugzilla.kernel.org/show_bug.cgi?id=208855
The status can now be set to RESOLVED FIXED. I don't have permission
to do that but perhaps either of you, Bjorn or Hans, has?
Also, the commit could optionally be amended with a Link: tag to that
bugzilla entry.
Thanks,
Lukas
next prev parent reply other threads:[~2022-01-12 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 14:17 [PATCH resend v2] PCI: pciehp: Use down_read/write_nested(reset_lock) to fix lockdep errors Hans de Goede
2022-01-11 17:14 ` Bjorn Helgaas
2022-01-12 8:28 ` Lukas Wunner [this message]
2022-01-12 12:39 ` Hans de Goede
2022-01-12 12:48 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112082801.GA19022@wunner.de \
--to=lukas@wunner.de \
--cc=hdegoede@redhat.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).