From: Bjorn Helgaas <helgaas@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: kys@microsoft.com, sunilmut@microsoft.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
wei.liu@kernel.org, decui@microsoft.com,
lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, mikelley@microsoft.com, maz@kernel.org,
linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next v2] PCI: hv: Fix an ignored error return from bitmap_find_free_region()
Date: Wed, 12 Jan 2022 08:26:32 -0600 [thread overview]
Message-ID: <20220112142632.GA252208@bhelgaas> (raw)
In-Reply-To: <20220112003324.62755-1-yang.lee@linux.alibaba.com>
On Wed, Jan 12, 2022 at 08:33:24AM +0800, Yang Li wrote:
> An error return from bitmap_find_free_region() is currently ignored
> and we instead return a completely bogus *hwirq from
> hv_pci_vec_alloc_device_irq().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: c10bdb758ca4 ("PCI: hv: Add arm64 Hyper-V vPCI support")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thanks, I squashed this into c10bdb758ca4.
> ---
>
> Change in v2:
> --According to Bjorn's suggestion, the corresponding changes were made.
> https://lore.kernel.org/lkml/20220111155412.GA142851@bhelgaas/
>
> drivers/pci/controller/pci-hyperv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 26c9c8ec0989..20ea2ee330b8 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -701,7 +701,7 @@ static int hv_pci_vec_alloc_device_irq(struct irq_domain *domain,
> irq_hw_number_t *hwirq)
> {
> struct hv_pci_chip_data *chip_data = domain->host_data;
> - unsigned int index;
> + int index;
>
> /* Find and allocate region from the SPI bitmap */
> mutex_lock(&chip_data->map_lock);
> --
> 2.20.1.7.g153144c
>
prev parent reply other threads:[~2022-01-12 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 0:33 [PATCH -next v2] PCI: hv: Fix an ignored error return from bitmap_find_free_region() Yang Li
2022-01-12 14:26 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112142632.GA252208@bhelgaas \
--to=helgaas@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=mikelley@microsoft.com \
--cc=robh@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).