From: Bjorn Helgaas <helgaas@kernel.org>
To: Keith Busch <kbusch@kernel.org>
Cc: "Stefan Roese" <sr@denx.de>,
linux-pci@vger.kernel.org, "Pali Rohár" <pali@kernel.org>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@xilinx.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Yao Hongbo" <yaohongbo@linux.alibaba.com>,
"Naveen Naidu" <naveennaidu479@gmail.com>
Subject: Re: [PATCH v3 2/2] PCI/AER: Enable AER on all PCIe devices supporting it
Date: Wed, 19 Jan 2022 15:00:02 -0600 [thread overview]
Message-ID: <20220119210002.GA963573@bhelgaas> (raw)
In-Reply-To: <20220119182550.GB13301@dhcp-10-100-145-180.wdc.com>
On Wed, Jan 19, 2022 at 10:25:50AM -0800, Keith Busch wrote:
> On Wed, Jan 19, 2022 at 10:22:00AM +0100, Stefan Roese wrote:
> > @@ -387,6 +387,10 @@ void pci_aer_init(struct pci_dev *dev)
> > pci_add_ext_cap_save_buffer(dev, PCI_EXT_CAP_ID_ERR, sizeof(u32) * n);
> >
> > pci_aer_clear_status(dev);
> > +
> > + /* Enable AER if requested */
> > + if (pci_aer_available())
> > + pci_enable_pcie_error_reporting(dev);
> > }
>
> Hasn't it always been the device specific driver's responsibility to
> call this function?
So far it has been done by the driver, because the PCI core doesn't do
it. But is there a reason it should be done by the driver? It
doesn't seem necessarily device-specific.
Bjorn
next prev parent reply other threads:[~2022-01-19 21:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 9:21 [PATCH v3 0/2] Fully enable AER Stefan Roese
2022-01-19 9:21 ` [PATCH v3 1/2] PCI/portdrv: Don't disable AER reporting in get_port_device_capability() Stefan Roese
2022-01-19 9:22 ` [PATCH v3 2/2] PCI/AER: Enable AER on all PCIe devices supporting it Stefan Roese
2022-01-19 10:37 ` Pali Rohár
2022-01-20 7:31 ` Stefan Roese
2022-01-20 13:23 ` Pali Rohár
2022-01-20 15:46 ` Bjorn Helgaas
2022-01-20 16:59 ` Stefan Roese
2022-01-20 17:54 ` Bjorn Helgaas
2022-01-19 18:25 ` Keith Busch
2022-01-19 21:00 ` Bjorn Helgaas [this message]
2022-01-19 21:18 ` Keith Busch
2022-01-20 7:32 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119210002.GA963573@bhelgaas \
--to=helgaas@kernel.org \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=naveennaidu479@gmail.com \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=yaohongbo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).