From: Bjorn Helgaas <helgaas@kernel.org>
To: Vikash Bansal <bvikas@vmware.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Srivatsa Bhat <srivatsab@vmware.com>,
"srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
Alexey Makhalov <amakhalov@vmware.com>,
Srinidhi Rao <srinidhir@vmware.com>,
Anish Swaminathan <anishs@vmware.com>,
Vasavi Sirnapalli <vsirnapalli@vmware.com>,
Ajay Kaher <akaher@vmware.com>
Subject: Re: [PATCH] PCI: Speed up device init by parsing capabilities all at once
Date: Fri, 21 Jan 2022 13:42:35 -0600 [thread overview]
Message-ID: <20220121194235.GA1146009@bhelgaas> (raw)
In-Reply-To: <7E2C2648-76CE-4987-AB4F-7B4576F10D7B@vmware.com>
On Fri, Jan 21, 2022 at 05:26:35PM +0000, Vikash Bansal wrote:
> On 20/01/22, 11:56 AM, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>
> Run pahole for pci_dev structure, it is not adding any padding bytes.
> Please refer to my previous email for replies to Greg's other comments.
Please don't indent your entire response. The original posting
apparently didn't go to linux-pci@vger.kernel.org or was rejected,
maybe because it wasn't plain text (see
http://vger.kernel.org/majordomo-info.html)?
It doesn't appear in the thread at
https://lore.kernel.org/all/7E2C2648-76CE-4987-AB4F-7B4576F10D7B@vmware.com/
> >On Tue, Jan 18, 2022 at 09:16:01AM -0800, Vikash Bansal wrote:
> >> In the current implementation, the PCI capability list is parsed from
> >> the beginning to find each capability, which results in a large number
> >> of redundant PCI reads.
> >>
> >> Instead, we can parse the complete list just once, store it in the
> >> pci_dev structure, and get the offset of each capability directly from
> >> the pci_dev structure.
> ...
next prev parent reply other threads:[~2022-01-21 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1642526161-22499-1-git-send-email-bvikas@vmware.com>
2022-01-20 6:26 ` [PATCH] PCI: Speed up device init by parsing capabilities all at once Greg KH
2022-01-20 17:31 ` Vikash Bansal
2022-01-22 19:09 ` Vikash Bansal
2022-01-21 17:26 ` Vikash Bansal
2022-01-21 19:42 ` Bjorn Helgaas [this message]
2022-01-22 2:12 ` Srivatsa S. Bhat
2022-01-22 18:51 ` Vikash Bansal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121194235.GA1146009@bhelgaas \
--to=helgaas@kernel.org \
--cc=akaher@vmware.com \
--cc=amakhalov@vmware.com \
--cc=anishs@vmware.com \
--cc=bhelgaas@google.com \
--cc=bvikas@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=srinidhir@vmware.com \
--cc=srivatsa@csail.mit.edu \
--cc=srivatsab@vmware.com \
--cc=vsirnapalli@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).