From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Keith Busch <kbusch@kernel.org>,
kw@linux.com, helgaas@kernel.org, lukas@wunner.de, pavel@ucw.cz,
linux-cxl@vger.kernel.org, martin.petersen@oracle.com,
James.Bottomley@hansenpartnership.com,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [RFC PATCH 2/3] Add PCIe enclosure management auxiliary driver
Date: Mon, 31 Jan 2022 12:59:15 +0100 [thread overview]
Message-ID: <20220131125915.0000294f@linux.intel.com> (raw)
In-Reply-To: <111e1684ab4a77c7ca4abc9f7fd1f37f9534d937.1642460765.git.stuart.w.hayes@gmail.com>
Hi Stuart,
On Mon, 17 Jan 2022 22:17:57 -0600
Stuart Hayes <stuart.w.hayes@gmail.com> wrote:
> + switch (output->status) {
> + case 0:
> + break;
> + case 1:
> + pci_dbg(pdev, "_DSM not supported\n");
> + break;
> + case 2:
> + pci_dbg(pdev, "_DSM invalid input parameters\n");
> + break;
> + case 3:
> + pci_dbg(pdev, "_DSM communication error\n");
> + break;
> + case 4:
> + pci_dbg(pdev, "_DSM function-specific error 0x%x\n",
> + output->function_specific_err);
> + break;
> + case 5:
> + pci_dbg(pdev, "_DSM vendor-specific error 0x%x\n",
> + output->vendor_specific_err);
> + break;
> + default:
> + pci_dbg(pdev, "_DSM returned unknown status 0x%x\n",
> + output->status);
> + }
> +}
I tired to compile it and I failed:
drivers/misc/enclosure.c: In function ‘led_show’:
drivers/misc/enclosure.c:607:3: error: label at end of compound
statement default:
^~~~~~~
drivers/misc/enclosure.c: In function ‘led_set’:
drivers/misc/enclosure.c:644:3: error: label at end of compound
statement default:
^~~~~~~
make[2]: *** [scripts/Makefile.build:288: drivers/misc/enclosure.o]
Error 1 make[1]: *** [scripts/Makefile.build:550: drivers/misc] Error 2
make[1]: *** Waiting for unfinished jobs....
My gcc version:
gcc (SUSE Linux) 7.5.0
Could you please, resolve the issue?
Thanks,
Mariusz
next prev parent reply other threads:[~2022-01-31 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 4:17 [RFC PATCH 0/3] Add PCIe enclosure management support Stuart Hayes
2022-01-18 4:17 ` [RFC PATCH 1/3] Add support for seven more indicators in enclosure driver Stuart Hayes
2022-01-18 6:16 ` Greg Kroah-Hartman
2022-01-18 4:17 ` [RFC PATCH 2/3] Add PCIe enclosure management auxiliary driver Stuart Hayes
2022-01-31 11:59 ` Mariusz Tkaczyk [this message]
2022-02-02 17:54 ` stuart hayes
2022-01-18 4:17 ` [RFC PATCH 3/3] Register auxiliary device for PCIe enclosure management Stuart Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131125915.0000294f@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=kw@linux.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=martin.petersen@oracle.com \
--cc=pavel@ucw.cz \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).