From: Bjorn Helgaas <helgaas@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Brent Spillner <spillner@acm.org>,
bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch:x86:pci:irq.c: Improve log message when IRQ cannot be identified
Date: Mon, 31 Jan 2022 15:22:13 -0600 [thread overview]
Message-ID: <20220131212213.GA510910@bhelgaas> (raw)
In-Reply-To: <8f820849-6940-4271-e678-1ae037cdfb64@intel.com>
On Fri, Jan 28, 2022 at 01:36:53PM -0800, Dave Hansen wrote:
> On 1/28/22 12:48, Brent Spillner wrote:
> > It seems like the multiline string literal is your main pain point--- would
> >
> > +#ifdef CONFIG_ACPI
> > + if (acpi_noirq)
> > + msg = "; consider removing acpi=noirq";
> > + else
> > + msg = "; recommend verifying UEFI/BIOS
> > IRQ options";
> > +#else
> > + msg = "; recommend verifying UEFI/BIOS IRQ
> > options or enabling ACPI";
> > +#endif
> >
> > be OK without going to IS_ENABLED()? (Personally, I think the #ifdef
> > style is more readable.)
>
> I think that's _better_ than what was in the patch. But, even with it,
> I still think the #ifdef mess borders on unreadable.
>
> But, if Bjorn likes it, then go for it. :)
I was hoping to avoid commenting at all ;)
I'm a little bit averse to suggesting *any* command-line options
because users shouldn't have to use options like these. It would be
better if we got a bug report and could fix the bug or add a quirk to
work around a firmware issue automatically.
If a user finds a command-line option that "works," the problem is
solved as far as they are concerned, but it doesn't help the next
person who trips over it.
I think pci_acpi_init() should warn when "acpi=noirq" was used because
the only reason to use it should be to work around a firmware defect,
and ideally, we could make a quirk to do that. Maybe the doc should
suggest a bug report.
What does "verifying UEFI/BIOS IRQ options" mean? I could go look at
the BIOS setup menu, but I would have no idea what to look for, so the
only thing I could do would be to try randomly changing IRQ-related
things. If that happens to hit on a working configuration, I might
be happy, but it wouldn't help the next person at all. I'd rather see
a bug report. Then we could at least try to make a quirk so no
command line option would be needed.
Bjorn
prev parent reply other threads:[~2022-01-31 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 17:37 [PATCH] arch:x86:pci:irq.c: Improve log message when IRQ cannot be identified Brent Spillner
2022-01-28 18:00 ` Dave Hansen
2022-01-28 20:48 ` Brent Spillner
2022-01-28 21:36 ` Dave Hansen
2022-01-31 21:22 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131212213.GA510910@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=spillner@acm.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).