* [helgaas-pci:for-linus 2/2] drivers/pci/controller/dwc/pcie-kirin.c:764:44: error: expected '}' before ';' token
@ 2022-02-02 18:45 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-02-02 18:45 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: kbuild-all, linux-pci
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git for-linus
head: 6b85e10dcff3a98d40f9fbbefc5bb854fa6b50c1
commit: 6b85e10dcff3a98d40f9fbbefc5bb854fa6b50c1 [2/2] PCI: kirin: Add dev struct for of_device_get_match_data()
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20220203/202202030204.2ItojgUO-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?id=6b85e10dcff3a98d40f9fbbefc5bb854fa6b50c1
git remote add helgaas-pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
git fetch --no-tags helgaas-pci for-linus
git checkout 6b85e10dcff3a98d40f9fbbefc5bb854fa6b50c1
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/pci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/pci/controller/dwc/pcie-kirin.c:764:44: error: expected '}' before ';' token
764 | .phy_type = PCIE_KIRIN_INTERNAL_PHY;
| ^
drivers/pci/controller/dwc/pcie-kirin.c:763:54: note: to match this '{'
763 | static const struct kirin_pcie_data kirin_960_data = {
| ^
drivers/pci/controller/dwc/pcie-kirin.c:768:44: error: expected '}' before ';' token
768 | .phy_type = PCIE_KIRIN_EXTERNAL_PHY;
| ^
drivers/pci/controller/dwc/pcie-kirin.c:767:54: note: to match this '{'
767 | static const struct kirin_pcie_data kirin_970_data = {
| ^
drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_probe':
>> drivers/pci/controller/dwc/pcie-kirin.c:790:14: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
790 | data = of_device_get_match_data(dev);
| ^
vim +764 drivers/pci/controller/dwc/pcie-kirin.c
762
763 static const struct kirin_pcie_data kirin_960_data = {
> 764 .phy_type = PCIE_KIRIN_INTERNAL_PHY;
765 };
766
767 static const struct kirin_pcie_data kirin_970_data = {
> 768 .phy_type = PCIE_KIRIN_EXTERNAL_PHY;
769 };
770
771 static const struct of_device_id kirin_pcie_match[] = {
772 { .compatible = "hisilicon,kirin960-pcie", .data = &kirin_960_data },
773 { .compatible = "hisilicon,kirin970-pcie", .data = &kirin_970_data },
774 {},
775 };
776
777 static int kirin_pcie_probe(struct platform_device *pdev)
778 {
779 struct kirin_pcie_data *data;
780 struct device *dev = &pdev->dev;
781 struct kirin_pcie *kirin_pcie;
782 struct dw_pcie *pci;
783 int ret;
784
785 if (!dev->of_node) {
786 dev_err(dev, "NULL node\n");
787 return -EINVAL;
788 }
789
> 790 data = of_device_get_match_data(dev);
791 if (!data) {
792 dev_err(dev, "OF data missing\n");
793 return -EINVAL;
794 }
795
796 kirin_pcie = devm_kzalloc(dev, sizeof(struct kirin_pcie), GFP_KERNEL);
797 if (!kirin_pcie)
798 return -ENOMEM;
799
800 pci = devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL);
801 if (!pci)
802 return -ENOMEM;
803
804 pci->dev = dev;
805 pci->ops = &kirin_dw_pcie_ops;
806 pci->pp.ops = &kirin_pcie_host_ops;
807 kirin_pcie->pci = pci;
808 kirin_pcie->type = data->phy_type;
809
810 ret = kirin_pcie_get_resource(kirin_pcie, pdev);
811 if (ret)
812 return ret;
813
814 platform_set_drvdata(pdev, kirin_pcie);
815
816 ret = kirin_pcie_power_on(pdev, kirin_pcie);
817 if (ret)
818 return ret;
819
820 return dw_pcie_host_init(&pci->pp);
821 }
822
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-02 18:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-02 18:45 [helgaas-pci:for-linus 2/2] drivers/pci/controller/dwc/pcie-kirin.c:764:44: error: expected '}' before ';' token kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).