From: Bjorn Helgaas <helgaas@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: bhelgaas@google.com, arnd@arndb.de, hch@infradead.org,
akpm@linux-foundation.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: Remove the deprecated "pci-dma-compat.h" API
Date: Thu, 10 Mar 2022 11:30:22 -0600 [thread overview]
Message-ID: <20220310173022.GA166412@bhelgaas> (raw)
In-Reply-To: <20220310170445.GA163749@bhelgaas>
On Thu, Mar 10, 2022 at 11:04:45AM -0600, Bjorn Helgaas wrote:
> On Wed, Mar 09, 2022 at 08:50:39PM +0100, Christophe JAILLET wrote:
> > Now that all usages of the functions defined in "pci-dma-compat.h" have
> > been removed, it is time to remove this file as well.
>
> As of 1db333d9a51f ("Merge tag 'spi-fix-v5.17-rc7' of
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi"), all the
> following still appear to be used:
>
> git grep -E "\<PCI_DMA_(BIDIRECTIONAL|TODEVICE|FROMDEVICE|NONE)"
> git grep -E "pci_(alloc|zalloc|free)_consistent"
> git grep -E "pci_(map|unmap)_single"
> git grep -E "\<pci_(map|unmap)_page"
> git grep -E "pci_(map|unmap)_sg"
> git grep -E "pci_dma_sync_"
> git grep pci_dma_mapping_error
> git grep -E "pci_set_.*dma_mask"
Christoph mentioned several other trees that this depends on, and
those would likely be in linux-next, but not yet in Linus' tree. The
above poking around is from the tip of Linus' tree, which was the
wrong place for me to look.
But I did the same in current linux-next, 71941773e143 ("Add
linux-next specific files for 20220310"), and still found quite a few
uses. Some are in comments, printks, coccinelle scripts, etc. I
would assume we'd want to remove them all?
Bjorn
next prev parent reply other threads:[~2022-03-10 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:50 [PATCH] PCI: Remove the deprecated "pci-dma-compat.h" API Christophe JAILLET
2022-03-09 22:10 ` Arnd Bergmann
2022-03-10 6:28 ` Christoph Hellwig
2022-03-10 17:04 ` Bjorn Helgaas
2022-03-10 17:30 ` Bjorn Helgaas [this message]
2022-03-29 18:18 ` Christoph Hellwig
2022-03-29 19:00 ` Bjorn Helgaas
2022-03-29 19:01 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310173022.GA166412@bhelgaas \
--to=helgaas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).