Re: [PATCH v1 1/1] PCI: Enable INTx quirk for ATI PCIe-USB adapter

Bjorn Helgaas
2022-03-14T19:43:06Z

On Mon, Mar 14, 2022 at 12:14:48PM +0200, Andy Shevchenko wrote:
> ATI PCIe-USB adapter advertises MSI, but it doesn't work if INTx is disabled.
> Enable the respective quirk as it's done for other ATI devices on this chipset,
>
> Fixes: 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

This is interesting because there must be a TON of these AMD/ATI SB600
USB devices in the field, and 306c54d0edb6 was merged in July 2020 and
appeared in v5.9.

So why would we only get a report now, in February 2022? Is there
some change more recent than 306c54d0edb6 that exposed this problem?

> BugLink: https://lore.kernel.org/all/20200702143045.23429-1-andriy.shevchenko@linux.intel.com/
> Reported-by: micklorain@protonmail.com
> Tested-by: micklorain@protonmail.com
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pci/quirks.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 65f7f6b0576c..cc6a87a32b62 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3041,6 +3041,13 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> PCI_DEVICE_ID_TIGON3_5715S,
> quirk_msi_intx_disable_bug);
>
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4386, quirk_msi_intx_disable_bug);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4387, quirk_msi_intx_disable_bug);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4388, quirk_msi_intx_disable_bug);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4389, quirk_msi_intx_disable_bug);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438a, quirk_msi_intx_disable_bug);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438b, quirk_msi_intx_disable_bug);
> +
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4390,
> quirk_msi_intx_disable_ati_bug);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4391,
> --
> 2.35.1
>