From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF74C433F5 for ; Thu, 24 Mar 2022 12:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349936AbiCXMOr (ORCPT ); Thu, 24 Mar 2022 08:14:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349882AbiCXMOp (ORCPT ); Thu, 24 Mar 2022 08:14:45 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FBB4BF43 for ; Thu, 24 Mar 2022 05:13:12 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id e5so4503548pls.4 for ; Thu, 24 Mar 2022 05:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Xl1mC6PbzMnFsI+v5sBw1bmmFK2u7TIp7uztHSDF11M=; b=Z7gkDEgEwX2MFq1RXHTDWu9NynVhi4kMvsYLWy2TNRnDG7A23UGQkCRpjZNwM40xM7 H/XLg2fTjDV4DDLXNcwnOdQe/v86CJ34bwkZOmCuISgLuJlkB0ti0fPjz6UYsKUtWSWD +LsgzMmfLQwB3huXSfLGeUQQyiO1agsOHpSmoEUEAStvNYFO4SQssXEquP4rFtwaj1iH 9+mawBfax7PzalW1m86UcIknYojN4ncAjRiIJbzXfjUFxCCqftqzvyN9BkFA6XTStF46 4/Z1xDQf/BxpHaZ/rfImYiTcxxJZXeZO7aEL/Lou1WDrDVVDh3A1CZUOR2Bwp5QC6sqZ FkLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Xl1mC6PbzMnFsI+v5sBw1bmmFK2u7TIp7uztHSDF11M=; b=7riW1zWoXFfSdXd2F0r1qwdSTkUtGqenLjkTMO96u9+vIH5MeIdLs8AZZ7LccG82SW NCc3jJ/ndMwIJ+MFpyMS4UwlX9WCo2G5fQhs2QUuhdRI+d0fHzgT43C/LLIsoH9AuhGa jJYIhmJ081He36DVrCLQ8bUOwvYvacWFp+uCJvbIHAPmn/WDBc0FCAksIP38x7TNIraL ns8g8M790mQaoXWm+EL3K/2SUue6YUDWxv1r1N283MpxYfvK3NRSpDeWK12091immx/U /o0b0xeIg5Nx6ikt8Nr4jL+tHr/wbkjBTYSadi5Na1QAbcN2mcyYzymeSbspoBOYImYC FsBA== X-Gm-Message-State: AOAM532t6IlM58axD+ciSPYRoZ+e1z2AzFcsolMAV3JmovEIq2rwY+HP BNkjdcUsT+vvoJDVFQYxqRJi X-Google-Smtp-Source: ABdhPJw3jkLtYM5wwwr1LLr6SoNvdyRBVfqxxlm1uh8eEUB4AHguTpOzun2ZSPO/98jTVzBcX7DNhg== X-Received: by 2002:a17:90b:4d82:b0:1c7:438d:241f with SMTP id oj2-20020a17090b4d8200b001c7438d241fmr18386615pjb.161.1648123992005; Thu, 24 Mar 2022 05:13:12 -0700 (PDT) Received: from thinkpad ([220.158.158.107]) by smtp.gmail.com with ESMTPSA id t26-20020a056a00139a00b004faa13ba384sm3561816pfg.162.2022.03.24.05.13.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 05:13:11 -0700 (PDT) Date: Thu, 24 Mar 2022 17:43:06 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/12] PCI: dwc: Add braces to the multi-line if-else statements Message-ID: <20220324121306.GF2854@thinkpad> References: <20220324012524.16784-1-Sergey.Semin@baikalelectronics.ru> <20220324012524.16784-7-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324012524.16784-7-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Mar 24, 2022 at 04:25:17AM +0300, Serge Semin wrote: > In accordance with [1] if there is at least one multi-line if-else > clause in the statement, then each clause will need to be surrounded by > the braces. The driver code violates that coding style rule in a few > places. Let's fix it. > > [1] Documentation/process/coding-style.rst > > Signed-off-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++-- > drivers/pci/controller/dwc/pcie-designware.c | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > index 0eda8236c125..7c9315fffe24 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > @@ -699,9 +699,9 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > if (!pci->dbi_base2) { > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2"); > - if (!res) > + if (!res) { > pci->dbi_base2 = pci->dbi_base + SZ_4K; > - else { > + } else { > pci->dbi_base2 = devm_pci_remap_cfg_resource(dev, res); > if (IS_ERR(pci->dbi_base2)) > return PTR_ERR(pci->dbi_base2); > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index d737af058903..9f4d2b44612b 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -699,8 +699,9 @@ void dw_pcie_iatu_detect(struct dw_pcie *pci) > pci->atu_size = SZ_4K; > > dw_pcie_iatu_detect_regions_unroll(pci); > - } else > + } else { > dw_pcie_iatu_detect_regions(pci); > + } > > dev_info(pci->dev, "iATU unroll: %s\n", pci->iatu_unroll_enabled ? > "enabled" : "disabled"); > -- > 2.35.1 >