From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D7BC433FE for ; Thu, 24 Mar 2022 17:15:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352181AbiCXRQx (ORCPT ); Thu, 24 Mar 2022 13:16:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347252AbiCXRQx (ORCPT ); Thu, 24 Mar 2022 13:16:53 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB91EB1891 for ; Thu, 24 Mar 2022 10:15:20 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id m18so536942plx.3 for ; Thu, 24 Mar 2022 10:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XWV/NU9KBDK+6NrxZTVbhSQcmAs/2MmqDrZDpchQ340=; b=ixCpJFtXz7n5lU0fj9BgLDP7UC3OMn8q9JBDP5g98XPWInsmFxPmbvXze0gWL3kvos 1QGYzP3u5O2ZU7ozLqiD6gvXMsg2XfWPmV9asM48DF0qw2h4qMbHKcDEaK8vTKLa6v88 J9FWnRtsNBe8ch/pOmydHp6kZAuUlo2luEiTZNWEAFJR/dUEbjs79SbkCWcWQy84Qd5j OBHBjavgjpBh6LSWKsxkWL2GiKYHQRD6QB6h1jUXlvh1YZcLGfxxdHX6YPcBzlZFCOqY un6peG8v7y5K4x3J105drZE5rLKBikz356aElBa7RFteeRAOAcAbbj8YChKdlhQd3ESv qUHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XWV/NU9KBDK+6NrxZTVbhSQcmAs/2MmqDrZDpchQ340=; b=Xy/iT8IQZIeeyGE3MX2/9pKg0twKMaLzuEOQRQwUhPuccuSve/4E8uAPokIvawwQpn SapsvOV2s+2U5UWcPZHby2CmWKFPODyoYi6X9Mxa7eKpQG4LBe6EfMaM5/znPJUJaNbS 5mt6+XWihBLr+uSbLPiZyU0epVRaGmAwBm2ri0r3novaQ5VJ2FT68A1QVuj3IABRHZxV Zj/RxEn/hpIJQI/5ABPL1YCEbhcte2jDA0Tk1ZSkzucLluk2gPI97nCms3bTmg/vaN59 PQKKUvaq5aVtguvNS8QuaCtR4Cyv9mn3g4gePPeUfpITe77g+Jh851eEZQyUCzHBHz+f r9UQ== X-Gm-Message-State: AOAM531plHqRSAil67DSN8EJnQBXfdze3HtfWPWsYiCoHZoq1WQSmbdc v21CmfEUPlNtHH8RJwaVuIfw X-Google-Smtp-Source: ABdhPJx3paZ+Kg390H0v1ZUeHXIdxQXx4drh90s6/ujRUve2+kXpx5NrwOSnlaSW3pdBF9MN3log9g== X-Received: by 2002:a17:90a:168f:b0:1b9:453a:fe79 with SMTP id o15-20020a17090a168f00b001b9453afe79mr19700814pja.107.1648142120256; Thu, 24 Mar 2022 10:15:20 -0700 (PDT) Received: from thinkpad ([27.111.75.218]) by smtp.gmail.com with ESMTPSA id h6-20020a636c06000000b00363a2533b17sm3063524pgc.8.2022.03.24.10.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 10:15:19 -0700 (PDT) Date: Thu, 24 Mar 2022 22:45:12 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Gustavo Pimentel , Vinod Koul , Jingoo Han , Bjorn Helgaas , Frank Li , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/25] dmaengine: dw-edma: Don't permit non-inc interleaved xfers Message-ID: <20220324171512.GQ2854@thinkpad> References: <20220324014836.19149-1-Sergey.Semin@baikalelectronics.ru> <20220324014836.19149-8-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324014836.19149-8-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Mar 24, 2022 at 04:48:18AM +0300, Serge Semin wrote: > DW eDMA controller always increments both source and destination > addresses. Permitting DMA interleaved transfers with no src_inc/dst_inc > flags set may lead to unexpected behaviour for the device users. Let's fix > that by terminating the interleaved transfers if at least one of the > dma_interleaved_template.{src_inc,dst_inc} flag is initialized with false > value. Note in addition to that we need we need to increase the source and > destination addresses accordingly after each iteration. > Can you please point me where this gets documented in databook? Thanks, Mani > Fixes: 85e7518f42c8 ("dmaengine: dw-edma: Add device_prep_interleave_dma() support") > Signed-off-by: Serge Semin > --- > drivers/dma/dw-edma/dw-edma-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c > index 2010d7f8191f..f41bde27795c 100644 > --- a/drivers/dma/dw-edma/dw-edma-core.c > +++ b/drivers/dma/dw-edma/dw-edma-core.c > @@ -386,6 +386,8 @@ dw_edma_device_transfer(struct dw_edma_transfer *xfer) > return NULL; > if (xfer->xfer.il->numf > 0 && xfer->xfer.il->frame_size > 0) > return NULL; > + if (!xfer->xfer.il->src_inc || !xfer->xfer.il->dst_inc) > + return NULL; > } else { > return NULL; > } > @@ -485,15 +487,13 @@ dw_edma_device_transfer(struct dw_edma_transfer *xfer) > struct dma_interleaved_template *il = xfer->xfer.il; > struct data_chunk *dc = &il->sgl[i]; > > - if (il->src_sgl) { > - src_addr += burst->sz; > + src_addr += burst->sz; > + if (il->src_sgl) > src_addr += dmaengine_get_src_icg(il, dc); > - } > > - if (il->dst_sgl) { > - dst_addr += burst->sz; > + dst_addr += burst->sz; > + if (il->dst_sgl) > dst_addr += dmaengine_get_dst_icg(il, dc); > - } > } > } > > -- > 2.35.1 >