Re: [PATCH V4 1/1] Intel Sky Lake-E host root ports check.

Jason Gunthorpe
2022-03-30T15:37:26Z

On Wed, Mar 30, 2022 at 05:08:23PM +0300, Shlomo Pongratz wrote:
> @@ -350,7 +353,10 @@ static struct pci_dev *pci_host_bridge_dev(struct pci_host_bridge *host)
>
> if (!root)
> return NULL;
> - if (root->devfn != PCI_DEVFN(0, 0))
> +
> + /* Is it a host bridge or a root port? */

This is a better comment:

/* host bridges must have a 0 devfn, but some of the entries in the
whilelist are root ports that can have any devfn */

> + if (root->devfn != PCI_DEVFN(0, 0) &&
> + pci_pcie_type(root) != PCI_EXP_TYPE_ROOT_PORT)
> return NULL;

Indentation is wrong

Jason