linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Stefan Roese <sr@denx.de>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 0/2] Add support to register platform service IRQ
Date: Fri, 1 Apr 2022 07:35:28 -0500	[thread overview]
Message-ID: <20220401123528.GA88442@bhelgaas> (raw)
In-Reply-To: <473f6f13-cf01-4065-5a92-998b651f11db@denx.de>

On Fri, Apr 01, 2022 at 08:28:51AM +0200, Stefan Roese wrote:
> On 3/31/22 17:30, Bjorn Helgaas wrote:
> > On Thu, Mar 24, 2022 at 05:52:54PM +0100, Stefan Roese wrote:
> > > On 1/14/22 08:58, Stefan Roese wrote:
> > > > Some platforms have dedicated IRQ lines for platform-specific System Errors
> > > > like AER/PME etc. The root complex on these platform will use these seperate
> > > > IRQ lines to report AER/PME etc., interrupts and will not generate
> > > > MSI/MSI-X/INTx interrupts for these services.
> > > > 
> > > > These patches will add new method for these kind of platforms to register the
> > > > platform IRQ number with respective PCIe services.
> > > > 
> > > > Changes in v4 (Stefan):
> > > > - Remove 2nd check for PCI_EXP_TYPE_ROOT_PORT
> > > > - Change init_platform_service_irqs() from void to return int
> > > > 
> > > > Changes in v3 (Stefan):
> > > > - Restructure patches from 4 patches in v2 to now 2 patches in v3
> > > > - Rename of functions names
> > > > - init_platform_service_irqs() now uses "struct pci_dev *" instead of
> > > >     "struct pci_host_bridge *"
> > > > - pcie_init_platform_service_irqs() is called before pcie_init_service_irqs()
> > > > - Use more PCIe spec terminology as suggested by Bjorn (hopefully enough, I
> > > >     don't have the spec at hand)
> > > 
> > > Bjorn, what's the status of this patchset? I was under the impression,
> > > that it would make it into v5.18. Please let me know if something is
> > > missing.
> > 
> > Sorry, I didn't get to it in time for v5.18, but it's on my list for
> > v5.19.
> > 
> > I thought maybe it got assigned to Lorenzo because it touches
> > drivers/pci/controller/, but I can't find it in patchwork
> > (https://patchwork.kernel.org/project/linux-pci/list/) at all.
> 
> Both patches are in patchwork:
> 
> https://patchwork.kernel.org/project/linux-pci/patch/20220114075834.1938409-2-sr@denx.de/
> https://patchwork.kernel.org/project/linux-pci/patch/20220114075834.1938409-3-sr@denx.de/
> 
> The first one is assigned to you and the 2nd one to Lorenzo.
> 
> > Would you mind posting it again to make sure patchwork picks it up?
> > If it's not in patchwork, it's very likely to get missed.
> 
> Since it's already on patchwork, I did not post the patches again.
> Please let me know if I should re-post them nevertheless.

No, that should be enough.  I spent 10 minutes searching patchwork
yesterday; don't know why I couldn't find it.

> > > > Bharat Kumar Gogada (2):
> > > >     PCI/portdrv: Add option to setup IRQs for platform-specific Service
> > > >       Errors
> > > >     PCI: xilinx-nwl: Add method to init_platform_service_irqs hook
> > > > 
> > > >    drivers/pci/controller/pcie-xilinx-nwl.c | 18 +++++++++++
> > > >    drivers/pci/pcie/portdrv_core.c          | 39 +++++++++++++++++++++++-
> > > >    include/linux/pci.h                      |  2 ++
> > > >    3 files changed, 58 insertions(+), 1 deletion(-)
> > > > 
> > > 
> > > Viele Grüße,
> > > Stefan Roese
> > > 
> > > -- 
> > > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
> 
> Viele Grüße,
> Stefan Roese
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

      reply	other threads:[~2022-04-01 12:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14  7:58 [PATCH v4 0/2] Add support to register platform service IRQ Stefan Roese
2022-01-14  7:58 ` [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors Stefan Roese
2022-01-14 11:46   ` Pali Rohár
2022-05-28  0:09   ` Bjorn Helgaas
2022-05-30  8:18     ` Stefan Roese
2022-05-30  8:32       ` Pali Rohár
2022-05-31 21:31         ` Bjorn Helgaas
2022-05-31 22:57           ` Pali Rohár
2022-06-01 11:47           ` Stefan Roese
2022-06-01 11:53             ` Pali Rohár
2022-06-08 18:39             ` Bjorn Helgaas
2022-01-14  7:58 ` [PATCH v4 2/2] PCI: xilinx-nwl: Add method to init_platform_service_irqs hook Stefan Roese
2022-01-14 11:48   ` Pali Rohár
2022-01-14 12:13     ` Stefan Roese
2022-01-14 12:34       ` Pali Rohár
2022-01-14 17:03         ` Stefan Roese
2022-03-24 16:52 ` [PATCH v4 0/2] Add support to register platform service IRQ Stefan Roese
2022-03-31 15:30   ` Bjorn Helgaas
2022-04-01  6:28     ` Stefan Roese
2022-04-01 12:35       ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401123528.GA88442@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).