From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAABEC433FE for ; Fri, 1 Apr 2022 15:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344959AbiDAPrU (ORCPT ); Fri, 1 Apr 2022 11:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349933AbiDAO6V (ORCPT ); Fri, 1 Apr 2022 10:58:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E08FE16E7DA; Fri, 1 Apr 2022 07:45:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E360760A53; Fri, 1 Apr 2022 14:45:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08B66C2BBE4; Fri, 1 Apr 2022 14:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648824329; bh=5TsJJ6l6iv2fS+LhvRzu5SBnx03YsVcVqVdyQ0qRQfY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q1ZIu5ZyD/HbchDlszgAa5lyq1ZLvSiyoug62OYNGgs1W0wDkgM0xqHX4eg8xAQox g0ZFvPVXZD9eMatRx2J9FfQ9Gr60+Y8q3GDYK5ht7In9WQ7yjYl4QdOSKyajvwxvYs wYgoNJbK6Powvp4GfUyGaiY9Z9jGYr2QopkUkK5QLi/tuGKNveKz8SnO8/qpqOwI+v FXwMN6Gq4PX/Cp75wjKM4hqoMSmKF2HXO1R8wqtclWPWprMNPt8x8qqZJVU2m6ZxZq uCmiOaj0sEqgegbfDglEmM5R8QG59rnkydQw+mHJ0cNGhGWtXguH/xKy1MWPiuSQTM mWZjvoOve9khg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Manivannan Sadhasivam , Bjorn Helgaas , Sasha Levin , lukas@wunner.de, hdegoede@redhat.com, naveennaidu479@gmail.com, sathyanarayanan.kuppuswamy@linux.intel.com, zhangliguang@linux.alibaba.com, mani@kernel.org, ameynarkhede03@gmail.com, linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 16/37] PCI: pciehp: Add Qualcomm quirk for Command Completed erratum Date: Fri, 1 Apr 2022 10:44:25 -0400 Message-Id: <20220401144446.1954694-16-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220401144446.1954694-1-sashal@kernel.org> References: <20220401144446.1954694-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Manivannan Sadhasivam [ Upstream commit 9f72d4757cbe4d1ed669192f6d23817c9e437c4b ] The Qualcomm PCI bridge device (Device ID 0x0110) found in chipsets such as SM8450 does not set the Command Completed bit unless writes to the Slot Command register change "Control" bits. This results in timeouts like below: pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) Add the device to the Command Completed quirk to mark commands "completed" immediately unless they change the "Control" bits. Link: https://lore.kernel.org/r/20220210145003.135907-1-manivannan.sadhasivam@linaro.org Signed-off-by: Manivannan Sadhasivam Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/pci/hotplug/pciehp_hpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 907b8be86ce0..a19157acc6dd 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -957,6 +957,8 @@ static void quirk_cmd_compl(struct pci_dev *pdev) } DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); +DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0110, + PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0400, PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0401, -- 2.34.1