From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102B2C433EF for ; Fri, 1 Apr 2022 15:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345164AbiDAPr3 (ORCPT ); Fri, 1 Apr 2022 11:47:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350280AbiDAO7b (ORCPT ); Fri, 1 Apr 2022 10:59:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6CF85A17B; Fri, 1 Apr 2022 07:46:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7B202B824D5; Fri, 1 Apr 2022 14:46:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAA95C2BBE4; Fri, 1 Apr 2022 14:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648824412; bh=CoLXnWVIKhJ5vBHDitAWSa245b6xFqXKoWrvAGnLIm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J/ofY+IXvvokGvB5nYaEIe4/UOfEnPWrFtaMYNBxKgX4zyJELp7Xt525XVLvBOBq+ S9FK3GtJM+6wExVbfLic6pnj8MvfOJF/eePKlslkVUHNk6qSqDfr46Zz5uTNija+hs +7uG+Rp+PBh+qT9zNiDn7sAeZK5QxtkC27qMHBCggtuq9gx+s1lOAVjquiwI3BrAyA eo1gxK5di83NL6278MVJY+gsevjYyoXQ9qMcv5hCvjnDZGidYOqbjQzlWvbl7iBecv etEtnL/NshBwvrlomoF3R0bs53aYaPya6PfpCjJHNvaVroirGPDjC6d3yDArzmqrHt 4g2OmAlAAvrMg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Manivannan Sadhasivam , Bjorn Helgaas , Sasha Levin , lukas@wunner.de, naveennaidu479@gmail.com, sathyanarayanan.kuppuswamy@linux.intel.com, zhangliguang@linux.alibaba.com, ameynarkhede03@gmail.com, hdegoede@redhat.com, mani@kernel.org, linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 13/29] PCI: pciehp: Add Qualcomm quirk for Command Completed erratum Date: Fri, 1 Apr 2022 10:45:56 -0400 Message-Id: <20220401144612.1955177-13-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220401144612.1955177-1-sashal@kernel.org> References: <20220401144612.1955177-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Manivannan Sadhasivam [ Upstream commit 9f72d4757cbe4d1ed669192f6d23817c9e437c4b ] The Qualcomm PCI bridge device (Device ID 0x0110) found in chipsets such as SM8450 does not set the Command Completed bit unless writes to the Slot Command register change "Control" bits. This results in timeouts like below: pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) Add the device to the Command Completed quirk to mark commands "completed" immediately unless they change the "Control" bits. Link: https://lore.kernel.org/r/20220210145003.135907-1-manivannan.sadhasivam@linaro.org Signed-off-by: Manivannan Sadhasivam Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/pci/hotplug/pciehp_hpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 53227232243f..502c307dee14 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -969,6 +969,8 @@ static void quirk_cmd_compl(struct pci_dev *pdev) } DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); +DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0110, + PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0400, PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0401, -- 2.34.1