From: David Stevens <stevensd@chromium.org>
To: linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
David Stevens <stevensd@chromium.org>
Subject: [RFC] PCI: sysfs: add bypass for config read admin check
Date: Wed, 6 Apr 2022 16:11:31 +0900 [thread overview]
Message-ID: <20220406071131.2930035-1-stevensd@google.com> (raw)
From: David Stevens <stevensd@chromium.org>
Add a moduleparam that can be set to bypass the check that limits users
without CAP_SYS_ADMIN to only being able to read the first 64 bytes of
the config space. This allows systems without problematic hardware to be
configured to allow users without CAP_SYS_ADMIN to read PCI
capabilities.
Signed-off-by: David Stevens <stevensd@chromium.org>
---
drivers/pci/pci-sysfs.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 602f0fb0b007..162423b3c052 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -28,10 +28,17 @@
#include <linux/pm_runtime.h>
#include <linux/msi.h>
#include <linux/of.h>
+#include <linux/moduleparam.h>
#include "pci.h"
static int sysfs_initialized; /* = 0 */
+static bool allow_unsafe_config_reads;
+module_param_named(allow_unsafe_config_reads,
+ allow_unsafe_config_reads, bool, 0644);
+MODULE_PARM_DESC(allow_unsafe_config_reads,
+ "Enable full read access to config space without CAP_SYS_ADMIN.");
+
/* show configuration fields */
#define pci_config_attr(field, format_string) \
static ssize_t \
@@ -696,7 +703,8 @@ static ssize_t pci_read_config(struct file *filp, struct kobject *kobj,
u8 *data = (u8 *) buf;
/* Several chips lock up trying to read undefined config space */
- if (file_ns_capable(filp, &init_user_ns, CAP_SYS_ADMIN))
+ if (allow_unsafe_config_reads ||
+ file_ns_capable(filp, &init_user_ns, CAP_SYS_ADMIN))
size = dev->cfg_size;
else if (dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)
size = 128;
--
2.35.1.1094.g7c7d902a7c-goog
next reply other threads:[~2022-04-06 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 7:11 David Stevens [this message]
2022-04-06 8:09 ` [RFC] PCI: sysfs: add bypass for config read admin check Greg Kroah-Hartman
2022-04-06 13:13 ` Pali Rohár
2022-04-12 7:51 ` David Stevens
2022-04-12 9:57 ` Greg Kroah-Hartman
2022-04-06 11:17 ` Bjorn Helgaas
2022-04-08 15:50 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406071131.2930035-1-stevensd@google.com \
--to=stevensd@chromium.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).