linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: kbuild-all@lists.01.org, linux-pci@vger.kernel.org,
	Bjorn Helgaas <helgaas@kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [helgaas-pci:pci/pm 1/1] drivers/pci/pci-driver.c:1315:9: error: implicit declaration of function 'pci_pm_default_resume_early'; did you mean 'pci_pm_default_resume'?
Date: Fri, 8 Apr 2022 02:09:27 +0800	[thread overview]
Message-ID: <202204080225.iXDZAkO2-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/pm
head:   53b3488879cff3b3a238e3e9651c2e2879f422cf
commit: 53b3488879cff3b3a238e3e9651c2e2879f422cf [1/1] PCI/PM: Power up all devices during runtime resume
config: i386-randconfig-a014 (https://download.01.org/0day-ci/archive/20220408/202204080225.iXDZAkO2-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?id=53b3488879cff3b3a238e3e9651c2e2879f422cf
        git remote add helgaas-pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
        git fetch --no-tags helgaas-pci pci/pm
        git checkout 53b3488879cff3b3a238e3e9651c2e2879f422cf
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/pci/pci-driver.c: In function 'pci_pm_runtime_resume':
>> drivers/pci/pci-driver.c:1315:9: error: implicit declaration of function 'pci_pm_default_resume_early'; did you mean 'pci_pm_default_resume'? [-Werror=implicit-function-declaration]
    1315 |         pci_pm_default_resume_early(pci_dev);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         |         pci_pm_default_resume
   At top level:
   drivers/pci/pci-driver.c:533:12: warning: 'pci_restore_standard_config' defined but not used [-Wunused-function]
     533 | static int pci_restore_standard_config(struct pci_dev *pci_dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +1315 drivers/pci/pci-driver.c

  1302	
  1303	static int pci_pm_runtime_resume(struct device *dev)
  1304	{
  1305		struct pci_dev *pci_dev = to_pci_dev(dev);
  1306		const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
  1307		pci_power_t prev_state = pci_dev->current_state;
  1308		int error = 0;
  1309	
  1310		/*
  1311		 * Restoring config space is necessary even if the device is not bound
  1312		 * to a driver because although we left it in D0, it may have gone to
  1313		 * D3cold when the bridge above it runtime suspended.
  1314		 */
> 1315		pci_pm_default_resume_early(pci_dev);
  1316	
  1317		if (!pci_dev->driver)
  1318			return 0;
  1319	
  1320		pci_fixup_device(pci_fixup_resume_early, pci_dev);
  1321		pci_pm_default_resume(pci_dev);
  1322	
  1323		if (prev_state == PCI_D3cold)
  1324			pci_bridge_wait_for_secondary_bus(pci_dev);
  1325	
  1326		if (pm && pm->runtime_resume)
  1327			error = pm->runtime_resume(dev);
  1328	
  1329		pci_dev->runtime_d3cold = false;
  1330	
  1331		return error;
  1332	}
  1333	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-04-07 18:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204080225.iXDZAkO2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=helgaas@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).