From: Bjorn Helgaas <helgaas@kernel.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH] PCI/docs: Fix references to DMA set mask function
Date: Thu, 21 Apr 2022 12:12:24 -0500 [thread overview]
Message-ID: <20220421171224.GA1412390@bhelgaas> (raw)
In-Reply-To: <165048747271.2959320.13475081883467312497.stgit@omen>
On Wed, Apr 20, 2022 at 02:45:05PM -0600, Alex Williamson wrote:
> The function is dma_set_mask(), fix a missed instance of the old
> pci_set_dma_mask() and a reference to a function that doesn't exist.
>
> Fixes: 05b0ebd06ae6 ("PCI/doc: cleanup references to the legacy PCI DMA API")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Applied to pci/misc for v5.19 with Christoph's reviewed-by, thank you!
> ---
> Documentation/PCI/pci.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst
> index 67a850b55617..cced568d78e9 100644
> --- a/Documentation/PCI/pci.rst
> +++ b/Documentation/PCI/pci.rst
> @@ -273,12 +273,12 @@ Set the DMA mask size
> While all drivers should explicitly indicate the DMA capability
> (e.g. 32 or 64 bit) of the PCI bus master, devices with more than
> 32-bit bus master capability for streaming data need the driver
> -to "register" this capability by calling pci_set_dma_mask() with
> +to "register" this capability by calling dma_set_mask() with
> appropriate parameters. In general this allows more efficient DMA
> on systems where System RAM exists above 4G _physical_ address.
>
> Drivers for all PCI-X and PCIe compliant devices must call
> -set_dma_mask() as they are 64-bit DMA devices.
> +dma_set_mask() as they are 64-bit DMA devices.
>
> Similarly, drivers must also "register" this capability if the device
> can directly address "coherent memory" in System RAM above 4G physical
>
>
prev parent reply other threads:[~2022-04-21 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 20:45 [PATCH] PCI/docs: Fix references to DMA set mask function Alex Williamson
2022-04-21 5:35 ` Christoph Hellwig
2022-04-21 17:12 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421171224.GA1412390@bhelgaas \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox