From: Bjorn Helgaas <helgaas@kernel.org>
To: "Kenneth R. Crudup" <kenny@panix.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Vidya Sagar <vidyas@nvidia.com>,
bhelgaas@google.com, lorenzo.pieralisi@arm.com,
hkallweit1@gmail.com, wangxiongfeng2@huawei.com,
mika.westerberg@linux.intel.com,
chris.packham@alliedtelesis.co.nz, yangyicong@hisilicon.com,
treding@nvidia.com, jonathanh@nvidia.com, abhsahu@nvidia.com,
sagupta@nvidia.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com,
Ricky Wu <ricky_wu@realtek.com>, Rajat Jain <rajatja@google.com>,
Prasad Malisetty <quic_pmaliset@quicinc.com>,
Victor Ding <victording@google.com>
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume
Date: Thu, 21 Apr 2022 16:11:03 -0500 [thread overview]
Message-ID: <20220421211103.GA1426981@bhelgaas> (raw)
In-Reply-To: <42f9a28-e67-ec2a-f6-9a8b58edd84d@panix.com>
On Thu, Apr 21, 2022 at 01:40:02PM -0700, Kenneth R. Crudup wrote:
> On Thu, 21 Apr 2022, Kai-Heng Feng wrote:
>
> > I went through the whole discussion again, maybe Kenneth's case is
> > also the result of pcie_aspm_pm_state_change()?
>
> > Since Kenneth is using TLP to switch ASPM between performance and
> > powersaving/powersupersaving, that means 'aspm_disabled' is false.
> > Hence the KOXIA NVMe stops working post suspend and Realtek card
> > reader toggles L1ss post hibernation.
>
> > Kenneth, can you please see if removing pcie_aspm_pm_state_change()
> > from pci_raw_set_power_state() helps?
> > Anyway, this can be easier to spot if dmesg was attached.
>
> Well, I haven't had an issue with resume/return from hibernate for quite some
> time, and the patch I'd reported a long time ago is now in the Linus' master
> I've been running. I believe a BIOS change from Dell fixed it up for me.
Which patch are you referring to?
Vidya's original patch [1] is not upstream, at least AFAIK. Well, it
*was* merged as 4257f7e008ea [2] in v5.11-rc1, but then reverted by
40fb68c7725a [3] in v5.11-rc7.
[1] https://lore.kernel.org/r/20220201123536.12962-1-vidyas@nvidia.com
[2] https://git.kernel.org/linus/4257f7e008ea
[3] https://git.kernel.org/linus/40fb68c7725a
next prev parent reply other threads:[~2022-04-21 21:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 12:35 [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume Vidya Sagar
2022-02-01 13:54 ` Kenneth R. Crudup
[not found] ` <8aa96f79-402-4897-424f-64a2c6893de8@panix.com>
2022-02-01 19:03 ` Kenneth R. Crudup
2022-02-01 19:05 ` Kenneth R. Crudup
2022-02-01 19:10 ` Kenneth R. Crudup
2022-02-01 19:24 ` Vidya Sagar
2022-02-01 22:25 ` Kenneth R. Crudup
2022-02-02 4:17 ` Vidya Sagar
2022-02-04 1:18 ` Kenneth R. Crudup
2022-02-04 5:37 ` Vidya Sagar
2022-02-04 23:02 ` Bjorn Helgaas
2022-02-04 23:17 ` Kenneth R. Crudup
2022-02-05 16:44 ` Vidya Sagar
[not found] ` <12fe557f-7336-1970-d8f0-5a93529cf8c1@panix.com>
2022-02-05 17:32 ` Kenneth R. Crudup
2022-02-05 17:33 ` Kenneth R. Crudup
2022-02-07 16:33 ` Bjorn Helgaas
2022-02-07 18:20 ` Kenneth R. Crudup
2022-02-15 13:10 ` Kenneth R. Crudup
2022-02-16 4:40 ` Vidya Sagar
2022-02-16 6:00 ` Kenneth R. Crudup
2022-02-16 13:11 ` Vidya Sagar
2022-04-12 22:50 ` Bjorn Helgaas
2022-04-13 0:19 ` Kai-Heng Feng
2022-04-14 16:41 ` Bjorn Helgaas
2022-04-15 14:26 ` Kai-Heng Feng
2022-04-15 21:25 ` Bjorn Helgaas
2022-04-21 6:16 ` Kai-Heng Feng
2022-04-21 20:36 ` Bjorn Helgaas
2022-04-21 20:40 ` Kenneth R. Crudup
2022-04-21 21:11 ` Bjorn Helgaas [this message]
2022-04-21 21:21 ` Kenneth R. Crudup
2022-04-13 13:26 ` Bjorn Helgaas
2022-11-23 21:44 ` Matthias Kaehlcke
2022-11-23 22:01 ` Kenneth R. Crudup
2022-11-24 0:07 ` Matthias Kaehlcke
2022-02-15 13:12 ` Kenneth R. Crudup
2022-02-04 11:23 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421211103.GA1426981@bhelgaas \
--to=helgaas@kernel.org \
--cc=abhsahu@nvidia.com \
--cc=bhelgaas@google.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=hkallweit1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kai.heng.feng@canonical.com \
--cc=kenny@panix.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mmaddireddy@nvidia.com \
--cc=quic_pmaliset@quicinc.com \
--cc=rajatja@google.com \
--cc=ricky_wu@realtek.com \
--cc=sagar.tv@gmail.com \
--cc=sagupta@nvidia.com \
--cc=treding@nvidia.com \
--cc=victording@google.com \
--cc=vidyas@nvidia.com \
--cc=wangxiongfeng2@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox