Re: [PATCH v9 1/9] dmaengine: dw-edma: Remove unused field irq in struct dw_edma_chip

[Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>]

On Fri, Apr 22, 2022 at 09:36:35AM -0500, Frank Li wrote:
> irq of struct dw_edma_chip was never used.
> It can be removed safely.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> ---
> Change from v7 to v9
>  - None
> Change from v6 to v7
>  - move to 1st patch
> Change from v5 to v6
>  - s/remove/Remove/ at subject
> Change from v4 to v5
>  - none
> new patch at v4
> 
>  drivers/dma/dw-edma/dw-edma-pcie.c | 1 -
>  include/linux/dma/edma.h           | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 44f6e09bdb531..b8f52ca10fa91 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -231,7 +231,6 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  	chip->dw = dw;
>  	chip->dev = dev;
>  	chip->id = pdev->devfn;
> -	chip->irq = pdev->irq;
>  
>  	dw->mf = vsec_data.mf;
>  	dw->nr_irqs = nr_irqs;
> diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h
> index cab6e18773dad..d4333e721588d 100644
> --- a/include/linux/dma/edma.h
> +++ b/include/linux/dma/edma.h
> @@ -18,13 +18,11 @@ struct dw_edma;
>   * struct dw_edma_chip - representation of DesignWare eDMA controller hardware
>   * @dev:		 struct device of the eDMA controller
>   * @id:			 instance ID
> - * @irq:		 irq line
>   * @dw:			 struct dw_edma that is filed by dw_edma_probe()
>   */
>  struct dw_edma_chip {
>  	struct device		*dev;
>  	int			id;
> -	int			irq;
>  	struct dw_edma		*dw;
>  };
>  
> -- 
> 2.35.1
>