From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3768DC433FE for ; Sat, 23 Apr 2022 11:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235350AbiDWLwz (ORCPT ); Sat, 23 Apr 2022 07:52:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234794AbiDWLwy (ORCPT ); Sat, 23 Apr 2022 07:52:54 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 856D5BC95 for ; Sat, 23 Apr 2022 04:49:57 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id c1so3874072pfo.0 for ; Sat, 23 Apr 2022 04:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bD0I91RPtpUdTHW6YTFj3yI+VIqkefD+3QomXi2VfVk=; b=TOLGF7/a34UPIzjT4NYmnYmSmnQy6P1Xud04wVFEIYZnynWB3Lo2ry+ki4VVwreVfT fIaFzk3B8nIqpTla5jxOQ9v65YaTu/7aQp5/no9BL3AZsc3EqiwhTNrefDOh9JqhieQU uK4+0H8gsjGoYSTaIikO6uuHjqDsmZFNjD4EBAjN8vVP8ShZ7Cs8c72HmUOVIc39YdaQ OaMEmZPXhsgV5PnQTRKKotIAZLhKkdixxAdfDeXZE15evyUvLQJbjwLX83wz7LL7SZwA z9T2jVK8Zq8ivlVFA8DRmy3SBV2bwCrU8rNw6ivSg3Y0GpRPARV3ioaf3qQ9pJ5ruuHk Qn0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bD0I91RPtpUdTHW6YTFj3yI+VIqkefD+3QomXi2VfVk=; b=DNethrMu0XcY8HLh3YUgoEFmlon31oIKiFTrs66o9UEGJKEY2AJaE9bByDu2jx527u QUBbhBtwYLSN3d3itshb2nPnWXyO2lYwknMs6IFHj0HmYvpisYF1FAZNi0EUhbLTe3a0 N14srRGnazeBjNzEk8OBGg8bWXWNmahffLEYOnvpD3SEtYbCKE1hcH0TCmHsrbMnQcZi KCNAU3Vy/zt2ANQ8djweeiQ3yO8pRWGiXVyYgLuvGxnFM6T9OR+hT1fLrQfNhiBEPp+k NDIwYSIgZufFPAGNp+CBQiZqUO1aykUccthxnlDZYPBJ1ErFsV95REWs7rwzygUN3iAS WPZA== X-Gm-Message-State: AOAM531gVOSlVIF7dckVPG0qotTKoJT85Qr+c6XNY2nDiRXnKHPa1KFX ow1gMm6BFkry1eKQyc/R9UDx X-Google-Smtp-Source: ABdhPJzSURchGfaoJkNECcT5mOvpxRf+IxN+aW3buOd2vagZyevAWhQeB6vxCJI5OqauQAlvKoSw1w== X-Received: by 2002:a63:7d49:0:b0:378:907d:1fc7 with SMTP id m9-20020a637d49000000b00378907d1fc7mr7718345pgn.252.1650714597019; Sat, 23 Apr 2022 04:49:57 -0700 (PDT) Received: from thinkpad ([117.207.28.196]) by smtp.gmail.com with ESMTPSA id x71-20020a62864a000000b0050ad2c24a39sm5852337pfd.205.2022.04.23.04.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 04:49:56 -0700 (PDT) Date: Sat, 23 Apr 2022 17:19:49 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: gustavo.pimentel@synopsys.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, linux-imx@nxp.com, linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, fancer.lancer@gmail.com, lznuaa@gmail.com, helgaas@kernel.org, vkoul@kernel.org, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, Sergey.Semin@baikalelectronics.ru Subject: Re: [PATCH v9 1/9] dmaengine: dw-edma: Remove unused field irq in struct dw_edma_chip Message-ID: <20220423114949.GD374560@thinkpad> References: <20220422143643.727871-1-Frank.Li@nxp.com> <20220422143643.727871-2-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422143643.727871-2-Frank.Li@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Apr 22, 2022 at 09:36:35AM -0500, Frank Li wrote: > irq of struct dw_edma_chip was never used. > It can be removed safely. > > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam Thanks, Mani > Reviewed-by: Serge Semin > --- > Change from v7 to v9 > - None > Change from v6 to v7 > - move to 1st patch > Change from v5 to v6 > - s/remove/Remove/ at subject > Change from v4 to v5 > - none > new patch at v4 > > drivers/dma/dw-edma/dw-edma-pcie.c | 1 - > include/linux/dma/edma.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c > index 44f6e09bdb531..b8f52ca10fa91 100644 > --- a/drivers/dma/dw-edma/dw-edma-pcie.c > +++ b/drivers/dma/dw-edma/dw-edma-pcie.c > @@ -231,7 +231,6 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, > chip->dw = dw; > chip->dev = dev; > chip->id = pdev->devfn; > - chip->irq = pdev->irq; > > dw->mf = vsec_data.mf; > dw->nr_irqs = nr_irqs; > diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h > index cab6e18773dad..d4333e721588d 100644 > --- a/include/linux/dma/edma.h > +++ b/include/linux/dma/edma.h > @@ -18,13 +18,11 @@ struct dw_edma; > * struct dw_edma_chip - representation of DesignWare eDMA controller hardware > * @dev: struct device of the eDMA controller > * @id: instance ID > - * @irq: irq line > * @dw: struct dw_edma that is filed by dw_edma_probe() > */ > struct dw_edma_chip { > struct device *dev; > int id; > - int irq; > struct dw_edma *dw; > }; > > -- > 2.35.1 >