From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9EBC433EF for ; Wed, 27 Apr 2022 07:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359137AbiD0H6K (ORCPT ); Wed, 27 Apr 2022 03:58:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359138AbiD0H6B (ORCPT ); Wed, 27 Apr 2022 03:58:01 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 702F31467DD for ; Wed, 27 Apr 2022 00:54:49 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id s137so844174pgs.5 for ; Wed, 27 Apr 2022 00:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=l5ta2NcdLy0veXom7gBreHDrt/omYROMofUj/QJzRM8=; b=ub4kODAFuZCRDRKfYL+qD4Qo+CC5tdnSwxRYRCnqEO3KEIulaZ3NT6zyxPTxYR3u8A dOtfrONzD2vym+sFJDS/tX41It6KoWXVffaoqU0cE7O5+VkRzqsaX9k1qBtfGxATMByD gSkQzbOUdRhfiDTmAmeg6SzkOa+NiiSfXwSpfl+UwxNmKNEPSfHCnPPuqWtEVLpDK0j/ 3dS4myD7J6mzDYPihhrmBm+0TsowSjHsSrrz4Oldum0dffE+ru1b6Pug0+LLNPRlRJka NzF/pj2Jan4AeVL99wU/WnsilnC7Q/83/Zo7qETXoIiWTHsJ/SwTJS9YG0Jy/EmTDq2S fNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l5ta2NcdLy0veXom7gBreHDrt/omYROMofUj/QJzRM8=; b=Xf0iZgZBwZU4mndkmUyAESaFe3XU3XgtPPPM1O6VoqVy6ZeLf2towmcK5nART685Z4 9uMSAbbRG2G6usEHLguEudDAQ/9f/zQ788gwc/mJB+1fO2AtjLdHl7u2BoCagTg2cc/m JOvrNNEw1ya+qrguJ4Mtj7YGnOhBO4ogs+HT1F4SqUZzGBA6CqJb5oJbK6KGis29fkpJ DkpQLBpgmpXKWxQ7P30UeN7z8hJwcHTXbj/6lN4Jyc16T8cro0VIFjTgGt6yZhTL7gpC 7yva54cnvCZHPonMVMAssaOqERhXe8jPVmULXVo2XvDO0Ofuc5nXhg6lgwRcRBTP/rNZ pcmA== X-Gm-Message-State: AOAM530/cDvvbH+0YeNUbQlJQ5x1T5fikvyvS9rtWq9pZsDHFGubq751 Dcz+HCvH7+u390W7B8Ujdl2KJilzDSlt X-Google-Smtp-Source: ABdhPJyldkjQ5JNmLeZGK1hjdo7V7D2TILQ767NfRf8ugq3VZL7555wG2pVU843qNVyDD+GX22SS0Q== X-Received: by 2002:a65:5b84:0:b0:398:fd62:6497 with SMTP id i4-20020a655b84000000b00398fd626497mr22570602pgr.179.1651046088864; Wed, 27 Apr 2022 00:54:48 -0700 (PDT) Received: from thinkpad ([117.207.26.174]) by smtp.gmail.com with ESMTPSA id h6-20020a056a00218600b004f65315bb37sm18792509pfi.13.2022.04.27.00.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 00:54:48 -0700 (PDT) Date: Wed, 27 Apr 2022 13:24:41 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Lorenzo Pieralisi , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Dmitry Baryshkov , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] PCI: qcom: Fix runtime PM imbalance on probe errors Message-ID: <20220427075441.GA2182@thinkpad> References: <20220401133854.10421-1-johan+linaro@kernel.org> <20220401133854.10421-2-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220401133854.10421-2-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Apr 01, 2022 at 03:38:53PM +0200, Johan Hovold wrote: > Drop the leftover pm_runtime_disable() calls from the late probe error > paths that would, for example, prevent runtime PM from being reenabled > after a probe deferral. > > Fixes: 6e5da6f7d824 ("PCI: qcom: Fix error handling in runtime PM support") > Cc: stable@vger.kernel.org # 4.20 > Cc: Bjorn Andersson > Signed-off-by: Johan Hovold Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 20a0e6533a1c..0b0bd71f1bd2 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1616,17 +1616,14 @@ static int qcom_pcie_probe(struct platform_device *pdev) > pp->ops = &qcom_pcie_dw_ops; > > ret = phy_init(pcie->phy); > - if (ret) { > - pm_runtime_disable(&pdev->dev); > + if (ret) > goto err_pm_runtime_put; > - } > > platform_set_drvdata(pdev, pcie); > > ret = dw_pcie_host_init(pp); > if (ret) { > dev_err(dev, "cannot initialize host\n"); > - pm_runtime_disable(&pdev->dev); > goto err_pm_runtime_put; > } > > -- > 2.35.1 >