From: Bjorn Helgaas <helgaas@kernel.org>
To: keliu <liuke94@huawei.com>
Cc: nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, kurt.schwemmer@microsemi.com,
logang@deltatee.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: pci: Directly use ida_alloc()/free()
Date: Fri, 27 May 2022 11:42:04 -0500 [thread overview]
Message-ID: <20220527164204.GA481720@bhelgaas> (raw)
In-Reply-To: <20220527072005.2360176-1-liuke94@huawei.com>
On Fri, May 27, 2022 at 07:20:05AM +0000, keliu wrote:
> Use ida_alloc()/ida_free() instead of deprecated
> ida_simple_get()/ida_simple_remove() .
>
> Signed-off-by: keliu <liuke94@huawei.com>
I see you got some feedback about a full name already (here's a
reference:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.17#n407)
so I'll wait for the update. When you do, please also update the
subject line to match previous drivers/pci/ history (use
"git log --oneline drivers/pci/" to see it).
The patch itself looks good to me. Thanks for doing this!
> ---
> drivers/pci/controller/vmd.c | 6 +++---
> drivers/pci/switch/switchtec.c | 7 +++----
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index eb05cceab964..efcb3a3ca65e 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -893,7 +893,7 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)
> return -ENOMEM;
>
> vmd->dev = dev;
> - vmd->instance = ida_simple_get(&vmd_instance_ida, 0, 0, GFP_KERNEL);
> + vmd->instance = ida_alloc(&vmd_instance_ida, GFP_KERNEL);
> if (vmd->instance < 0)
> return vmd->instance;
>
> @@ -934,7 +934,7 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)
> return 0;
>
> out_release_instance:
> - ida_simple_remove(&vmd_instance_ida, vmd->instance);
> + ida_free(&vmd_instance_ida, vmd->instance);
> kfree(vmd->name);
> return err;
> }
> @@ -957,7 +957,7 @@ static void vmd_remove(struct pci_dev *dev)
> vmd_cleanup_srcu(vmd);
> vmd_detach_resources(vmd);
> vmd_remove_irq_domain(vmd);
> - ida_simple_remove(&vmd_instance_ida, vmd->instance);
> + ida_free(&vmd_instance_ida, vmd->instance);
> kfree(vmd->name);
> }
>
> diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
> index c36c1238c604..75be4fe22509 100644
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -1376,8 +1376,7 @@ static struct switchtec_dev *stdev_create(struct pci_dev *pdev)
> dev->groups = switchtec_device_groups;
> dev->release = stdev_release;
>
> - minor = ida_simple_get(&switchtec_minor_ida, 0, 0,
> - GFP_KERNEL);
> + minor = ida_alloc(&switchtec_minor_ida, GFP_KERNEL);
> if (minor < 0) {
> rc = minor;
> goto err_put;
> @@ -1692,7 +1691,7 @@ static int switchtec_pci_probe(struct pci_dev *pdev,
> err_devadd:
> stdev_kill(stdev);
> err_put:
> - ida_simple_remove(&switchtec_minor_ida, MINOR(stdev->dev.devt));
> + ida_free(&switchtec_minor_ida, MINOR(stdev->dev.devt));
> put_device(&stdev->dev);
> return rc;
> }
> @@ -1704,7 +1703,7 @@ static void switchtec_pci_remove(struct pci_dev *pdev)
> pci_set_drvdata(pdev, NULL);
>
> cdev_device_del(&stdev->cdev, &stdev->dev);
> - ida_simple_remove(&switchtec_minor_ida, MINOR(stdev->dev.devt));
> + ida_free(&switchtec_minor_ida, MINOR(stdev->dev.devt));
> dev_info(&stdev->dev, "unregistered.\n");
> stdev_kill(stdev);
> put_device(&stdev->dev);
> --
> 2.25.1
>
prev parent reply other threads:[~2022-05-27 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 7:20 [PATCH] drivers: pci: Directly use ida_alloc()/free() keliu
2022-05-27 16:42 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527164204.GA481720@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jonathan.derrick@linux.dev \
--cc=kurt.schwemmer@microsemi.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuke94@huawei.com \
--cc=logang@deltatee.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).